Re: [quicwg/base-drafts] Improve HTTP draft wording: frames carry identifier values (#3689)

Mike Bishop <notifications@github.com> Wed, 27 May 2020 15:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F9943A0E92 for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 08:19:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ju7Nzk14zRsJ for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 08:19:08 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 91D873A0E8D for <quic-issues@ietf.org>; Wed, 27 May 2020 08:19:08 -0700 (PDT)
Received: from github-lowworker-d1d6e31.ash1-iad.github.net (github-lowworker-d1d6e31.ash1-iad.github.net [10.56.105.50]) by smtp.github.com (Postfix) with ESMTP id 5910C6E1F3F for <quic-issues@ietf.org>; Wed, 27 May 2020 08:19:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590592746; bh=/Da+E5LlCRNd4f+U3aLQMMoXybMd5hjgNm8QfTj6Ozk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cxl4l7bCPCBY0AAGyvYfKX5gB35/MMUgbEveCdPVJkYP1CQuyBycPwXWJaRWfenhM 5XUevjVqruJo4chzpzR6xTLVxA/NaCOJEk0NfOv54fGBY704hBzQT+27EIxvxrJMvT Y75cEGa9ilkZOAsAQzAVSLJ/sWWCiypwB6I5z0f8=
Date: Wed, 27 May 2020 08:19:06 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2LRJGEAXRAI4MVCNN43JS6VEVBNHHCKKKFHA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3689/review/419325576@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3689@github.com>
References: <quicwg/base-drafts/pull/3689@github.com>
Subject: Re: [quicwg/base-drafts] Improve HTTP draft wording: frames carry identifier values (#3689)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ece84ea4a459_28023fcd01ccd9641850c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dYYb_ejT17vYRGf0ipIw9jzCSrg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 15:19:10 -0000

@MikeBishop commented on this pull request.

Maybe, given the ambiguity, the right answer is to get rid of "they" in the first place?

> @@ -954,7 +954,7 @@ might have acted on.
 A client that is unable to retry requests loses all requests that are in flight
 when the server closes the connection.  An endpoint MAY send multiple GOAWAY
 frames indicating different identifiers, but MUST NOT increase the identifier

```suggestion
frames indicating different identifiers, but the identifier in each frame
```

> +value they carry, since clients might already have retried unprocessed requests
 on another connection.

```suggestion
MUST NOT be greater than the identifier in any previous frame, since clients
might already have retried unprocessed requests on another connection.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3689#pullrequestreview-419325576