Re: [quicwg/base-drafts] Refactor the section on connection termination (#721)
Mike Bishop <notifications@github.com> Wed, 23 August 2017 16:29 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0001713202D for <quic-issues@ietfa.amsl.com>; Wed, 23 Aug 2017 09:29:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.999
X-Spam-Level:
X-Spam-Status: No, score=-6.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3lK-a0xta4kK for <quic-issues@ietfa.amsl.com>; Wed, 23 Aug 2017 09:29:20 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext1.iad.github.net [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 79600132025 for <quic-issues@ietf.org>; Wed, 23 Aug 2017 09:29:19 -0700 (PDT)
Date: Wed, 23 Aug 2017 09:29:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1503505758; bh=JsVfsRcCvezBcA1p2Ru7MNJwmb0gpdL+qQ3c3ak19oE=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eCenpKUHRHY5OstRZQKBcNLW0jj/DvhEs16jzA665zkhD8fc1bgHOJTk5+cZdKS5w 2FigzPqMVi9FnWUdqWmyZFq3wtH2ZhP+wuN64CSPX5UAg7oPcRTVNURJLquhe7Gp/c YbdMRnYpYWQvOvCf9yn7N9RFRm0s2OajdndCCJPQ=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1dcc928aa8beb92f0a313a38061b7403a996ca3792cf0000000115b56f5e92a169ce0edf94fd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/721/review/58138369@github.com>
In-Reply-To: <quicwg/base-drafts/pull/721@github.com>
References: <quicwg/base-drafts/pull/721@github.com>
Subject: Re: [quicwg/base-drafts] Refactor the section on connection termination (#721)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_599dad5ebc4f6_47d73f885806dc341445a9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dmmFpR6MHN0sG-u8odbq6G_bXcA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Aug 2017 16:29:22 -0000
MikeBishop commented on this pull request.
> +connection state if they have neither sent nor received a packet for this time.
+
+The time at which an idle timeout takes effect won't be perfectly synchronized
+on peers. A connection enters the draining period when the idle timeout
+expires. During this time, an endpoint that receives new packets MAY choose to
+restore the connection. Alternatively, an endpoint that receives packets MAY
+signal the timeout using an immediate close.
+
+
+### Immediate Close
+
+An endpoint sends a CONNECTION_CLOSE frame to terminate the connection
+immediately. A CONNECTION_CLOSE causes all open streams to immediately become
+closed; open streams can be assumed to be implicitly reset. After receiving a
+CONNECTION_CLOSE frame, endpoints MUST NOT send additional packets on that
+connection.
This probably falls under the above clause:
> In all cases, it is possible to acknowledge packets that are received as normal, but other reactions might be preferrable depending on how the connection was closed.
However, that's in conflict with the MUST NOT in this paragraph.
> +
+After a connection is closed for any reason, an endpoint might receive packets
+from its peer. These packets might have been sent prior to receiving any close
+signal, or they might be retransmissions of packets for which acknowledgments
+were lost.
+
+The draining period persists for three times the maximum of minimum RTO
+(kMinRTOTimeout) or the round trip time (smoothed_rtt), see {{QUIC-RECOVERY}}
+for descriptions of these values. During this period, new packets can be
+attributed to the correct connection and acknowledged, but the connection is no
+longer considered active and usable.
+
+Different treatment is given to packets that are received while a connection is
+in the draining period depending on how the connection was closed. In all
+cases, it is possible to acknowledge packets that are received as normal, but
+other reactions might be preferrable depending on how the connection was closed.
"preferable", not "preferrable"
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/721#pullrequestreview-58138369
- [quicwg/base-drafts] Refactor the section on conn… Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … janaiyengar
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Nick Banks
- Re: [quicwg/base-drafts] Refactor the section on … Mike Bishop
- Re: [quicwg/base-drafts] Refactor the section on … Mike Bishop
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … MikkelFJ
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Mike Bishop
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Roni Even
- Re: [quicwg/base-drafts] Refactor the section on … Roni Even
- Re: [quicwg/base-drafts] Refactor the section on … Patrick McManus
- Re: [quicwg/base-drafts] Refactor the section on … Roni Even
- Re: [quicwg/base-drafts] Refactor the section on … janaiyengar
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson
- Re: [quicwg/base-drafts] Refactor the section on … Martin Thomson