Re: [quicwg/base-drafts] Endpoints MAY (not SHOULD) ignore IPv4 ICMP PTB messages (#2109)

Igor Lubashev <notifications@github.com> Wed, 12 December 2018 18:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2A6771311F4 for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 10:35:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JZrFo9WPUK-K for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 10:35:54 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A1A81311F2 for <quic-issues@ietf.org>; Wed, 12 Dec 2018 10:35:54 -0800 (PST)
Date: Wed, 12 Dec 2018 10:35:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544639753; bh=WM2i0ZGrsZnNvYE8XjE5ecmOY47xIgo2U9T9NBsFrOQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DnRflI2mMgA9UseCSqSBlrBgM0eqVkxxqgN8WlRshgCrKqiNWSvtK0dB7wHMP+hXh 4u8PUO1Ujcgdn3wPFfBDVp1H2rJKkCUNSyDBPTNJjG3Kq82jxMl8Q7KgCtoozpNCgc PjLqOMgvD6AeLpQcBOZa1AIqw377IKUDDLFVd2LI=
From: Igor Lubashev <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc0732bfb6b94c27d0ebde09851e0814dc86cf55692cf000000011829170992a169ce1731b88c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2109/c446695165@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2109@github.com>
References: <quicwg/base-drafts/pull/2109@github.com>
Subject: Re: [quicwg/base-drafts] Endpoints MAY (not SHOULD) ignore IPv4 ICMP PTB messages (#2109)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c11550933ba2_74643fd6242d45bc143748"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: igorlord
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/do4yrfVcCZiJDdp7oklbzBMLqP8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Dec 2018 18:35:56 -0000

DPLPMTUD is not a requirement for all QUIC implementations.  The SHOULD in question is written as a requirement for all.

Looking at DPLPMTUD, however, I am realizing that it is possible that the question is moot.  DPLPMTUD draft (#3.4) considers doing anything at all (like simply matching to an existing connection using IP addresses) sufficient for validation (it says that doing more for validation is a SHOULD, implying that just matching IPs is still acceptable).  Since doing anything less is impractical when processing PTB messages, any implementation that uses PTB messages is implicitly validating them.  If so, I'd be happy with some text making it explicit that just matching on IPs and, maybe, UDP ports is sufficient to consider PTB validated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2109#issuecomment-446695165