[quicwg/base-drafts] 5.6 Packet Number Protection is hard to follow (#1387)

Tatsuhiro Tsujikawa <notifications@github.com> Thu, 24 May 2018 12:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ABAF612DA6F for <quic-issues@ietfa.amsl.com>; Thu, 24 May 2018 05:09:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hALfMnfhA_Hk for <quic-issues@ietfa.amsl.com>; Thu, 24 May 2018 05:09:28 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3A2312DA16 for <quic-issues@ietf.org>; Thu, 24 May 2018 05:09:28 -0700 (PDT)
Date: Thu, 24 May 2018 05:09:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1527163767; bh=+9OqI6usloZnjJMHuOSZiP41BxKsZcvH9NJFEu43gz8=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=jAPRYPE4d+ZoWY3jL+GhKHTJu0TOa6/qyQf960GG17Wl3p8yHKzcENzBWzlmSQEYi YyHB1KtUcy7tuT6udZXsRjp4/7DA7fIhW3PC2tnlycT0gIfkGCbP/+LPl1chOZVmrH rp1h0MZcLeqjHmY/KVSuV55x/3kDZ8toL6zX9caw=
From: Tatsuhiro Tsujikawa <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1ecdd7db99bd9ae8d5dce0e77cf726d11bb0a73e92cf00000001171e6d7792a169ce136fc559@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1387@github.com>
Subject: [quicwg/base-drafts] 5.6 Packet Number Protection is hard to follow (#1387)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b06ab771d900_604f3f919329af7c5246f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: tatsuhiro-t
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dokHlQdTKP0MHnBgP-e2DZ4YmFc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2018 12:09:31 -0000

It is hard to understand TLS 5.6 Packet Number Protection.

More specifically, this text block:

"""
   In sampling the packet ciphertext, the packet number length is
   assumed to be the smaller of the maximum possible packet number
   encoding (4 octets), or the size of the protected packet minus the
   minimum expansion for the AEAD.  For example, the sampled ciphertext
   for a packet with a short header can be determined by:

   "sample_offset = min(1 + connection_id_length + 4, packet_length -
   aead_expansion) sample =
   packet[sample_offset..sample_offset+sample_length] "
"""

It is ambiguous that what packet_length is.  Is it the Packet length field in Long packet header?  But it does not appear in Short header.  Is it the length of (Protected) Payload?  Or the length of QUIC packet?

The text says "the packet number length is ...", but the example seems to be offset to the byte to sample.

It would be also nice to show the example of Long packet.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1387