Re: [quicwg/base-drafts] Clarify RTT calculations in recovery (#2506)

Jana Iyengar <notifications@github.com> Tue, 02 April 2019 22:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57C05120340 for <quic-issues@ietfa.amsl.com>; Tue, 2 Apr 2019 15:22:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1ZiMrAY2MPr7 for <quic-issues@ietfa.amsl.com>; Tue, 2 Apr 2019 15:22:16 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 62F87120114 for <quic-issues@ietf.org>; Tue, 2 Apr 2019 15:22:16 -0700 (PDT)
Date: Tue, 02 Apr 2019 15:22:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554243735; bh=yBy5A9UFsE3Bz7vwRVrM+jbZYBiKQlWy00AJM0jhAhY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YNTVlSMfPzshDUwVUOEQFmLbSu6rP/Mz12wuzNmFXYblSC/f4MJdgvl4+YwaCArY/ srfcsuYx60+R3CEYQkOu++blxk16CJb7L5Cmf4P16F+S11zGdiIscVuE4gin/aVy7U isIHKzV0UaQEr9yaY5OOuXDecL2S2qEbnxrH4UKE=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab56699f0b41f4e51ab7681affff392d27fad28d8492cf0000000118bba29792a169ce18f867ef@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2506/review/221930818@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2506@github.com>
References: <quicwg/base-drafts/pull/2506@github.com>
Subject: Re: [quicwg/base-drafts] Clarify RTT calculations in recovery (#2506)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ca3e0977a76b_1ce73fdf3f4d45b42428b4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ds9GszxWiwEztc0s8aO02HRpHpU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Apr 2019 22:22:18 -0000

janaiyengar commented on this pull request.



>  
 min_rtt is the minimum RTT measured over the connection, prior to adjusting by
 ack delay.  Ignoring ack delay for min RTT prevents intentional or unintentional
 underestimation of min RTT, which in turn prevents underestimating smoothed RTT.
 
+A sender calculates both smoothed RTT (SRTT) and RTT variance (RTTVAR) similar
+to those specified in {{?RFC6298}}.  Note that smoothed_rtt does for the first

```suggestion
to those specified in {{?RFC6298}}.  Note that computing smoothed_rtt for the first
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2506#pullrequestreview-221930818