Re: [quicwg/base-drafts] Fix spelling and style consistency nits (#3946)

[Jana Iyengar <[e-mail]>]

@janaiyengar commented on this pull request.

Thanks, Lars, a few suggestions.

> @@ -3667,12 +3667,12 @@ acknowledgements.
 
 An endpoint measures the delays intentionally introduced between the time the
 packet with the largest packet number is received and the time an acknowledgment
-is sent.  The endpoint encodes this delay in the Ack Delay field of an ACK
+is sent.  The endpoint encodes this delay in the ACK Delay field of an ACK

We shouldn't use "ACK delay" without defining it, and if we do, I would suggest using "acknowledgement delay" instead.

> @@ -3667,12 +3667,12 @@ acknowledgements.
 
 An endpoint measures the delays intentionally introduced between the time the
 packet with the largest packet number is received and the time an acknowledgment
-is sent.  The endpoint encodes this delay in the Ack Delay field of an ACK
+is sent.  The endpoint encodes this delay in the ACK Delay field of an ACK
 frame; see {{frame-ack}}.  This allows the receiver of the ACK to adjust for any

```suggestion
frame; see {{frame-ack}}.  This allows the receiver of the ACK frame to adjust for any
```

> @@ -3720,7 +3720,7 @@ containing that information is acknowledged.
   unless the endpoint has sent a RESET_STREAM for that stream.  Once an endpoint
   sends a RESET_STREAM frame, no further STREAM frames are needed.
 
-* ACK frames carry the most recent set of acknowledgements and the Ack Delay
+* ACK frames carry the most recent set of acknowledgements and the ACK delay

how about "and the acknowledgement delay from the largest acknowledged packet ({{host-delay}})" ?

> @@ -5284,8 +5284,9 @@ ACK Delay:
   to the power of the value of the ack_delay_exponent transport parameter set by
   the sender of the ACK frame; see {{transport-parameter-definitions}}.  Scaling
   in this fashion allows for a larger range of values with a shorter encoding at
-  the cost of lower resolution.  Because the receiver doesn't use the ACK Delay
-  for Initial and Handshake packets, a sender SHOULD send a value of 0.
+  the cost of lower resolution.  Because the receiver doesn't use the value in
+  the ACK Delay field for Initial and Handshake packets, a sender SHOULD send a

```suggestion
  the ACK Delay field of Initial and Handshake packets, a sender SHOULD send a
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3946#pullrequestreview-454479546