IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140)

ianswett <notifications@github.com> Tue, 18 December 2018 21:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ACD21126F72 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 13:57:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ybIDggLSDokp for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 13:57:55 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E5B2B129BBF for <quic-issues@ietf.org>; Tue, 18 Dec 2018 13:57:54 -0800 (PST)
Date: Tue, 18 Dec 2018 13:57:54 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545170274; bh=kh7o8FYEfz6x2OAvs57r9VisVKfscXPr4zDgJy+WH3Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mVxeL6/R2cX/36Y4qT0onrViUqigevqgPnH565K6uZ7tEYNOGWat6mWgJHy5XZU8K cpJ0sO/b6Xyicg1WXjAxpJJflu8x/YNZD+ReIE5JDQ3MnPKYD8vthLSZJrO3iPPDZL FCMzozk2u76Bp/JdBe5pwW0xLax792N5CwUj0Rf4=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8ffdf9f5bdcedc0ffd7f2ec159e64b75434355fb92cf0000000118312f6292a169ce174729c1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2140/review/186301643@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2140@github.com>
References: <quicwg/base-drafts/pull/2140@github.com>
Subject: Re: [quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c196d626fa0_1c823fa0a3ad45c05389b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/e6Z412wZtVc5mKvE3onkzAI_3Rc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 21:57:57 -0000

ianswett commented on this pull request.



> @@ -716,6 +717,9 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
 
 ~~~
   OnAckReceived(ack):
+    largest_acked_packet = max(largest_acked_packet,

It's the case when one packet is far out of order, and then subsequent packets arrive in order.  ie: 100 is received, then 1, 2, 3, 4, 5, etc.  I don't fully understand the cause, but I've seen small UDP packets jump ahead of large ones in a number of traces.

But I suspect Jana and I will merge this as is and we can add follow-up text about that issue if we think it's valuable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2140#discussion_r242721000

v2.23.0 | Report a Bug | By Email