Re: [quicwg/base-drafts] Replace the RequireInsertCount decoding algorithm (#2379)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.



> -
-      if CurrentWrapped >= InsertCount + MaxEntries:
-         # Insert Count wrapped around 1 extra time
-         ReqInsertCount += 2 * MaxEntries
-      else if CurrentWrapped + MaxEntries < InsertCount:
-         # Decoder wrapped around 1 extra time
-         CurrentWrapped += 2 * MaxEntries
-
-      ReqInsertCount += TotalNumberOfInserts - CurrentWrapped
+      MaxValue = TotalNumberOfInserts + MaxEntries
+      # MaxWrapped is the largest possible value of
+      # ReqInsertCount that is 0 mod 2*MaxEntries
+      MaxWrapped = floor(MaxValue / FullRange) * FullRange
+      ReqInsertCount = MaxWrapped + EncodedInsertCount - 1
+      if ReqInsertCount > MaxValue:
+         # The Encoder's value wrapped one fewer time

This comment looks like it is attached to the next if statement rather than being an explanation of what the outer if statement is.  Maybe move it above the first if and say "# If this exceeds the maximum possible value, the encoder must have wrapped one fewer time" or something along those lines.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2379#pullrequestreview-197324242