Re: [quicwg/base-drafts] Request to Retire Locally Issued CIDs (#2769)

Nick Banks <notifications@github.com> Tue, 04 June 2019 21:40 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D77F61200A4 for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 14:40:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.605
X-Spam-Level:
X-Spam-Status: No, score=-1.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C7cRt_5AV0X3 for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 14:40:49 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D5830120098 for <quic-issues@ietf.org>; Tue, 4 Jun 2019 14:40:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=YfdRHDXZFWAJrJHpfrj9KsPG4YE=; b=Xn+RKyZ+QASH8BaJ ao/mXPT0GsIrrd9DHu2JNnTvty3zw1aAiHBlCyNo2zwnAH+llNvIcFAKBtlBeF6E 8WPjUMiHjivmgCPDe2JIhC7gsNiFxBVHCG1vYIov9180jqKi6AGwthIwHjfjCN6g uzuJlp5UDXh9ukhsfLg+OVSO4Vw=
Received: by filter1203p1las1.sendgrid.net with SMTP id filter1203p1las1-22837-5CF6E55F-D 2019-06-04 21:40:47.418825074 +0000 UTC m=+519045.804304031
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [140.82.115.8]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id toBkq1vrTmuPriqpG8YP5w for <quic-issues@ietf.org>; Tue, 04 Jun 2019 21:40:47.264 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id 32F2E1606FB for <quic-issues@ietf.org>; Tue, 4 Jun 2019 14:40:47 -0700 (PDT)
Date: Tue, 04 Jun 2019 21:40:47 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3HLHXV4P2AKYEISAV3AQL57EVBNHHBV45H2U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2769/review/245717977@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2769@github.com>
References: <quicwg/base-drafts/pull/2769@github.com>
Subject: Re: [quicwg/base-drafts] Request to Retire Locally Issued CIDs (#2769)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cf6e55f3128f_b373fab66ecd960226112"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2P5fnO9qa8B39WmAj4jJ7+v/04ycdU/94Hrw 7QVpxjw0r/exve6t43F0/iD9AMQ2vKzDMYSIN55ecdx/PXnbIqL2eNx1304vgXdRjaNiSy84WIoomH p1bUMs/oSTuSyxrwey+205mI6MblH84lyAWf0Q4jwZhgG/qe5zDvTGMEYVUccdFHW7XSnyLqxsKNhw A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eBAZSti6HqIX_p6dAo0eYXQ5XvE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jun 2019 21:40:51 -0000

nibanks commented on this pull request.



> @@ -5018,10 +5034,16 @@ sequence number, or if a sequence number is used for different connection
 IDs, the endpoint MAY treat that receipt as a connection error of type
 PROTOCOL_VIOLATION.
 
+If the Retire Prior To field is present it is a request for the peer to
+immediately retire all connection IDs with a sequence number less than the
+specified value.  For more information see {{retiring-cids}}.  This field
+should only ever increase, though reordering and retransmission of older packets
+may make it seem to decrease.  So any decrease in this field should be ignored.
+

We have the same problem with flow control values. We allow for implementations to naively retransmit packets that were lost, as is, so it's possible you have already updated the prior to field in a more recent packet, but then retransmit an older packet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2769#discussion_r290508547