IETF Logo Mail Archive

Re: [quicwg/base-drafts] loss of only two packets can lead to an unrecoverable situation (#2267)

Christian Huitema <notifications@github.com> Wed, 16 January 2019 01:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 76A1A130DD6 for <quic-issues@ietfa.amsl.com>; Tue, 15 Jan 2019 17:56:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8NJActO6IkOL for <quic-issues@ietfa.amsl.com>; Tue, 15 Jan 2019 17:56:34 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 638B312785F for <quic-issues@ietf.org>; Tue, 15 Jan 2019 17:56:34 -0800 (PST)
Date: Tue, 15 Jan 2019 17:56:33 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547603793; bh=8JjdHNP+bJ4XAb8mnP8b9s4x+YEYkUQbNXn7j3IO67Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0od7fsBkHwGmxuvxjX0pdb5CUD9Z77cs9pyjKC8eZx5f3/JHOhWRQXKz0x29w4xHr 2XoSrGMfBs9hUvGTykIApVtbRMFzYVxDIz3L0qU2yVrfqKVwVbJ1JcSiFhrcykwDyL M8DLnM4lwcaSMzaYK4zzIVXr/wmrfYYOTR6rXbCg=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab80e952a034d61695c370c26873f0b7e157e051d792cf000000011856515192a169ce1784eaec@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2267/454621847@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2267@github.com>
References: <quicwg/base-drafts/issues/2267@github.com>
Subject: Re: [quicwg/base-drafts] loss of only two packets can lead to an unrecoverable situation (#2267)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3e8f51b6fce_12cb3f9d304d45c4213395"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eFPL_GqQTgVvhIVvFEvpbGA63Eg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2019 01:56:36 -0000

@ianswett I don't think that you can drop the Handshake send keys unilaterally just because you received a 1RTT ACK. You can safely mark all the locally sent handshake packets as acknowledged, and you know that they will never need to be retransmitted. But if you receive a repeated handshake packet from the peer, it means that the peer is not implementing implicit ACK, and also is expecting an ACK on the repeated handshake packet. If you don't send the ACK, the peer could repeat the handshake packet N times and drop the connection.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2267#issuecomment-454621847

v2.23.0 | Report a Bug | By Email