Re: [quicwg/base-drafts] Send complete SETTINGS (#2972)
Martin Thomson <notifications@github.com> Mon, 26 August 2019 23:44 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 95F25120811 for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 16:44:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VKdtsI1am15n for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 16:44:25 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71411120EE0 for <quic-issues@ietf.org>; Mon, 26 Aug 2019 16:44:22 -0700 (PDT)
Date: Mon, 26 Aug 2019 16:44:21 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566863061; bh=Lje2vjuHp7MB9SD67Fy3I8BAg381wiznQcd8aayDtRk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZnAboF3XKivVs24Xf5fFMUcDhkbqcX2RvkX7C1zu9pZgqK74ts2c8hGkFtk+Gvc19 IfkwjVuXREuUVkldXGYAiZYSkETuHmrxzXrJ1NM5Pp5BqQT7cGcLLe8z/oOnAFr2kc jnC2NwKsOe7bV+FwSilabROAZdlbdUSRlN3GJ3o4=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6YGLVMQVPPTPAAXTN3OGJULEVBNHHBZNSWTM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2972/review/279891170@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2972@github.com>
References: <quicwg/base-drafts/pull/2972@github.com>
Subject: Re: [quicwg/base-drafts] Send complete SETTINGS (#2972)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d646ed5ae605_67b73fce83ccd968114606"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eHcsYacxTUnbM4sVNPFdZOsFV0Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2019 23:44:28 -0000
martinthomson approved this pull request. This seems like the right answer to me. I get the desire to find a more general solution, but I am concerned that we don't know what "general" looks like. This works well enough. It's complicated to write it down, but I don't think that it's all that complicated in practice. > -initial value of each server setting is the value used in the previous session. -Clients MUST store the settings the server provided in the session being resumed -and MUST comply with stored settings until the current server settings are -received. A client can use these initial values to send requests before the -server's SETTINGS frame has arrived. This removes the need for a client to wait -for the SETTINGS frame before sending requests. +setting is the default value. 1-RTT keys will always become available prior to +SETTINGS arriving, even if the server sends SETTINGS immediately. Clients SHOULD +NOT wait indefinitely for SETTINGS to arrive before sending requests, but SHOULD +process received datagrams in order to increase the likelihood of processing +SETTINGS before sending the first request. + +When a 0-RTT QUIC connection is being used, the initial value of each server +setting is the value used in the previous session. Clients SHOULD store the +settings the server provided in the connection where resumption information was +provided, but MAY opt not to store settings in certain cases (e.g. if the ```suggestion provided, but MAY opt not to store settings in certain cases (e.g., if the ``` > A server can remember the settings that it advertised, or store an integrity-protected copy of the values in the ticket and recover the information when accepting 0-RTT data. A server uses the HTTP/3 settings values in -determining whether to accept 0-RTT data. +determining whether to accept 0-RTT data. If the server cannot determine that +the settings remembered by a client are compatible with its current settings, it +MUST NOT accept 0-RTT data. (Remembered settings are compatible if a client ```suggestion MUST NOT accept 0-RTT data. Remembered settings are compatible if a client ``` > A server can remember the settings that it advertised, or store an integrity-protected copy of the values in the ticket and recover the information when accepting 0-RTT data. A server uses the HTTP/3 settings values in -determining whether to accept 0-RTT data. +determining whether to accept 0-RTT data. If the server cannot determine that +the settings remembered by a client are compatible with its current settings, it +MUST NOT accept 0-RTT data. (Remembered settings are compatible if a client +complying with those settings would not violate the server's current settings.) ```suggestion complying with those settings would not violate the server's current settings. ``` > A server MAY accept 0-RTT and subsequently provide different settings in its SETTINGS frame. If 0-RTT data is accepted by the server, its SETTINGS frame MUST NOT reduce any limits or alter any values that might be violated by the client -with its 0-RTT data. The server MAY omit settings from its SETTINGS frame which -are unchanged from the initial value. +with its 0-RTT data. The server MUST include all settings which differ from +their default values. If a server accepts 0-RTT, but then sends a SETTINGS +frame which reduces a setting the client understands or omits a value that was +previous specified, this MUST be treated as a connection error of type ```suggestion previously specified to have a non-default value, this MUST be treated as a connection error of type ``` The "ly" is just grammar, but I think that it would be OK to have a server send a default value in connection 1 and omit the value in connection 2. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2972#pullrequestreview-279891170
- [quicwg/base-drafts] Http/complete settings (#297… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Lucas Pardue
- Re: [quicwg/base-drafts] Send complete SETTINGS (… David Schinazi
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Nick Harper
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Martin Thomson
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Kazuho Oku
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Kazuho Oku
- Re: [quicwg/base-drafts] Send complete SETTINGS (… David Benjamin
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Martin Thomson
- Re: [quicwg/base-drafts] Send complete SETTINGS (… David Benjamin
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Kazuho Oku
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… ianswett
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Martin Thomson
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Lucas Pardue
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Lucas Pardue
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop
- Re: [quicwg/base-drafts] Send complete SETTINGS (… Mike Bishop