Re: [quicwg/base-drafts] Invalid Push ID error codes (#2818)
Kazuho Oku <notifications@github.com> Fri, 21 June 2019 05:29 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 83252120026 for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 22:29:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.391
X-Spam-Level:
X-Spam-Status: No, score=-6.391 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WXQ7h0qNg22a for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 22:29:46 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99001120018 for <quic-issues@ietf.org>; Thu, 20 Jun 2019 22:29:46 -0700 (PDT)
Date: Thu, 20 Jun 2019 22:29:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561094985; bh=5vncptcKJnip6/7YlzCDTrD/JjqfcYcZK/p45Jr9NYU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tC7tio0LcwQCWB6DJ9kwZYJZcnQ64qiOPqtZkJ81LY2a2i/3DeCDmvcSuMZiTJWbH MvSwk5rffg5ROnt1jK42w8RIvAXPA6TqH2pZwc2VzdiZlUSSYOeHx65uMbky4f7t8N MfDHrm9320KMlRJE15X9ybM5aM15kHYB7BuCNU3A=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK47O46B3L5HVWJVJ2F3DGO4TEVBNHHBWVZWUQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2818/504295038@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2818@github.com>
References: <quicwg/base-drafts/issues/2818@github.com>
Subject: Re: [quicwg/base-drafts] Invalid Push ID error codes (#2818)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0c6b49401f5_3413fe3daccd960155668"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eNTZ5F5uF46MdxnxSpCDqckliw8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2019 05:29:49 -0000
To me it seems that having an error code for specific part of push (i.e. ID of push-related information being incorrect) a bit too detailed. I think it sticks out, because we do not have things like PLACEHOLDER_ID_ERROR, STREAM_ID_ERROR. Also, using PUSH_ID_ERROR in some cases while using MALFORMED_FRAME in others seems confusing. I think we might want to consider doing either of the two: * Use PUSH_ID_ERROR (or a generic error code for push) for all the push-related errors. This makes sense if we consider push as an optional feature of HTTP/3 * Introduce ID_ERROR that captures all the limit and ID errors. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2818#issuecomment-504295038
- [quicwg/base-drafts] Iinvalid Push ID error codes… Lucas Pardue
- Re: [quicwg/base-drafts] Invalid Push ID error co… Kazuho Oku
- Re: [quicwg/base-drafts] Invalid Push ID error co… Lucas Pardue
- Re: [quicwg/base-drafts] Invalid Push ID error co… Lucas Pardue
- Re: [quicwg/base-drafts] Invalid Push ID error co… Mike Bishop
- Re: [quicwg/base-drafts] Invalid Push ID error co… Lucas Pardue
- Re: [quicwg/base-drafts] Invalid Push ID error co… Lucas Pardue