Re: [quicwg/base-drafts] Byte counting at Congestion avoidance (#3917)

[ianswett <[e-mail]>]

@ianswett commented on this pull request.

This is a slightly larger change than I first realized because it moves CWND increments from bytes to packets.  I'm trying to decide how much that matters in practice.

> @@ -1560,6 +1566,7 @@ window.
      if (!InCongestionRecovery(sent_time)):
        congestion_recovery_start_time = now()
        congestion_window *= kLossReductionFactor
+       bytes_acked *= kLossReductionFactor

Thanks for the explanation.  I think I'm fine either way, but questions like this are one of the reason I liked the old approach of assuming it's the implementation's responsibility to deal with rounding/etc.

Reading this again, I realize there's a somewhat substantive difference in behavior between the previous pseudocode and this PR, because the previous pseudocode would increment CWND in bytes, not only max_datagram_size.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3917#pullrequestreview-456031588