IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add max_ack_delay transport parameter and ACK every two packets (#1781)

Martin Thomson <notifications@github.com> Fri, 21 September 2018 23:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 09D15130E6E for <quic-issues@ietfa.amsl.com>; Fri, 21 Sep 2018 16:38:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wzGDQnSM6YOz for <quic-issues@ietfa.amsl.com>; Fri, 21 Sep 2018 16:38:14 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 00C4B130E41 for <quic-issues@ietf.org>; Fri, 21 Sep 2018 16:38:13 -0700 (PDT)
Date: Fri, 21 Sep 2018 16:38:12 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537573092; bh=+G4UwBpUOun3mVWu4YIB5xn1lVu0FzQKu2GvZjEG2MM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SSMcnnHw8H6BOpp+J3Hi7IrHYkOdHKs/pfHAirZ6fYT/XzLKtQYiAZXzEzim0Gq// vRHntPbHUcIZ6XyT2g6EKNStdhPIDzlOXtbQVSwKOMWjHVbMo+QPU7FwdOUiTPCUHe lx8GBk81Jmm6hgCaFk9KyYjx3TByPYglZo2JE2I8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb10136a4e60c80886010e1dd346b290265bfaf4492cf0000000117bd42e492a169ce1599ab93@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1781/review/157886983@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1781@github.com>
References: <quicwg/base-drafts/pull/1781@github.com>
Subject: Re: [quicwg/base-drafts] Add max_ack_delay transport parameter and ACK every two packets (#1781)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba580e49c2af_3113faef80d45bc1099c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eUfMeTLfIMki58tDy9_N03dBcSs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Sep 2018 23:38:17 -0000

martinthomson commented on this pull request.



> @@ -3461,9 +3468,14 @@ ACK frames in response to other packets.  Implementations MUST NOT send more
 than one packet containing only an ACK frame per received packet that contains
 frames other than ACK and PADDING frames.  Packets containing frames besides
 ACK and PADDING MUST be acknowledged immediately or when a delayed ack timer
-expires. The delayed ack timer MUST NOT delay an ACK for longer than an RTT or
-the alarm granularity.  This ensures an ACK frame is sent at least once per RTT
-if new packets needing acknowledgement were received.
+expires.
+
+The receiver's delayed ack timer MUST NOT delay an ACK for longer than an RTT
+or the value indicated by the `max_ack_delay` transport parameter.

you say that it might exceed `max_ack_delay` in the recovery PR, so which is it?

> @@ -3461,9 +3468,14 @@ ACK frames in response to other packets.  Implementations MUST NOT send more
 than one packet containing only an ACK frame per received packet that contains
 frames other than ACK and PADDING frames.  Packets containing frames besides
 ACK and PADDING MUST be acknowledged immediately or when a delayed ack timer
-expires. The delayed ack timer MUST NOT delay an ACK for longer than an RTT or
-the alarm granularity.  This ensures an ACK frame is sent at least once per RTT
-if new packets needing acknowledgement were received.
+expires.
+
+The receiver's delayed ack timer MUST NOT delay an ACK for longer than an RTT
+or the value indicated by the `max_ack_delay` transport parameter.
+This ensures an ACK frame is sent at least once per RTT if new packets
+needing acknowledgement were received and ensures the sender has a predictable
+limit on the ack delay for timer based retransmissions.  ACKs should be sent

I think we're gonna need caps on that should.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1781#pullrequestreview-157886983

v2.30.2 | Report a Bug | By Email | System Status