IETF Logo Mail Archive

Re: [quicwg/base-drafts] Allow longer CIDs (#2749)

MikkelFJ <notifications@github.com> Tue, 04 June 2019 21:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3855D1205F3 for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 14:02:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.391
X-Spam-Level:
X-Spam-Status: No, score=-6.391 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oATsUjukZbHX for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 14:02:31 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B66ED120432 for <quic-issues@ietf.org>; Tue, 4 Jun 2019 14:02:31 -0700 (PDT)
Date: Tue, 04 Jun 2019 14:02:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1559682150; bh=m63L8L77NKbmBzizZ8fDO0QhlsfNf7PR0BD23OWoI3g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BUUCJUsVTgJ8qruP+zSwLpRugUobEBzyeclsWRbZ0bpJ6HQLQbMlNmAI8Ws5YCbPh QYj0eOc6KZ6Z8lFlAn7tFtcUb714MQGjCnkapzxjKggdWd4liFJG81hjjfoxu9tNbg wwLMe7C2BylscVxdwWZ+W5A1d+00P1ppb5IXxccg=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6CR2KOSUJRCPWOV553AQHONEVBNHHBVJ2RLQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2749/review/245701492@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2749@github.com>
References: <quicwg/base-drafts/pull/2749@github.com>
Subject: Re: [quicwg/base-drafts] Allow longer CIDs (#2749)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cf6dc662ebf0_4a113fb7edccd9601314c5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eWOea093MBcBak4v6LtzxBs224Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jun 2019 21:02:34 -0000

mikkelfj commented on this pull request.



> @@ -2345,7 +2345,7 @@ following layout:
  0                   1                   2                   3
  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-|0|1|               Unpredictable Bits (182..)                ...
+|0|1|               Unpredictable Bits (422..)                ...

I still think we should allow responding to smaller packets at some random factor rather than not responding at all. This does not mean we should not try to keep resets small though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2749#discussion_r290495871

v2.23.0 | Report a Bug | By Email