Re: [quicwg/base-drafts] Editorial recovery fixes (#1551)
janaiyengar <notifications@github.com> Sat, 14 July 2018 21:58 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D4D1E130EFF for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 14:58:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OY2SVuCCc8V9 for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 14:58:21 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B86F312F1AC for <quic-issues@ietf.org>; Sat, 14 Jul 2018 14:58:21 -0700 (PDT)
Date: Sat, 14 Jul 2018 14:58:21 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531605501; bh=49EJpDd9QuCAHrDC4Iq3r7xG0/eIpHlc3Vu12Gs5uMM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Gk7WVk64I7509LyFw968V/Ex0Ku2IbuA1vv18pT2gUnPVo565Z++CjyYJxsNTIUCs w5JxsmgCwoEjPGAiMt8jWuA8CG6Cz6MHK0NPADqU1sOFHZpVV5nDu2DNFRPrFuxZV8 kPaPOYinFx7Db36kp85e4/xjYnL6QhkbBDScLcPI=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9771caf976f27b6cd38a701e9b2cd734df345ee192cf00000001176233fd92a169ce144b173f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1551/review/137249484@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1551@github.com>
References: <quicwg/base-drafts/pull/1551@github.com>
Subject: Re: [quicwg/base-drafts] Editorial recovery fixes (#1551)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4a71fd1def7_11e93ff9c07baf802606e8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eg4Da31k0c0Kr7bHEP6FRiwE8qQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jul 2018 21:58:24 -0000
janaiyengar commented on this pull request.
> +the acknowledgement indicates that a later packet was received, while the
+reordering threshold provides some tolerance for reordering of packets in the
+network.
+
+The RECOMMENDED initial value for kReorderingThreshold is 3, based on
+TCP loss recovery {{?RFC5681}} {{?RFC6675}}. Some networks may exhibit higher
+degrees of reordering, causing a sender to detect spurious losses. Spuriously
+declaring packets lost leads to unnecessary retransmissions and may result in
+degraded performance due to the actions of the congestion controller upon
+detecting loss. Implementers MAY use algorithms developed for TCP, such as
+TCP-NCR {{?RFC4653}}, to improve QUIC's reordering resilience.
+
+QUIC implementations may use time-based loss detection to deal with reordering.
+time-based loss detection allows a certain amount of reordering above
+max(SRTT, latest_rtt). The RECOMMENDED reordering tolerance is
+1/8 max(SRTT, latest_rtt).
This should be reworded. How about: "QUIC implementations can use time-based loss detection to handle reordering based on time elapsed since the packet was sent, instead of a packet reordering threshold. The RECOMMENDED time threshold, expressed as a fraction of the round-trip time (kTimeReorderingFraction), is 1/8." (The details of SRTT, etc are in the algo below, so I think being generic is ok here.)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1551#pullrequestreview-137249484
- [quicwg/base-drafts] Editorial fixes (#1551) ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… Martin Thomson
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… Mike Bishop
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… MikkelFJ
- Re: [quicwg/base-drafts] Editorial recovery fixes… janaiyengar
- Re: [quicwg/base-drafts] Editorial recovery fixes… janaiyengar
- Re: [quicwg/base-drafts] Editorial recovery fixes… janaiyengar
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… janaiyengar
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett
- Re: [quicwg/base-drafts] Editorial recovery fixes… ianswett