Re: [quicwg/base-drafts] Clarify when timer should be set (#3390)

ianswett <notifications@github.com> Tue, 04 February 2020 22:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 73C96120164 for <quic-issues@ietfa.amsl.com>; Tue, 4 Feb 2020 14:05:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e-PdW1QJQH-e for <quic-issues@ietfa.amsl.com>; Tue, 4 Feb 2020 14:05:10 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B5E11120130 for <quic-issues@ietf.org>; Tue, 4 Feb 2020 14:05:10 -0800 (PST)
Date: Tue, 04 Feb 2020 14:05:08 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580853909; bh=cFsLWBJAzOtiih098WJ/jE7qd/8NmuMYwU8bAC6N05Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qhWp02iBARqlyKzzPDNX6NVoEsvObHQU9tbBTIkvrkgYUvNtX9Yravvi7K8jP829A BzB583BsNRf6SxThpmk9aml57hpXxkZ/7mVtE/X1ThgMJwIaV68USi/jNCbsHfg61R 6SkfBy7O3Ceo7XdbML607kAtansKzEnq98L2xt9o=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY6LU4MQMBIHZJ5R454I4ORJEVBNHHCCBXGCQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3390/review/353335253@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3390@github.com>
References: <quicwg/base-drafts/pull/3390@github.com>
Subject: Re: [quicwg/base-drafts] Clarify when timer should be set (#3390)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e39ea94ed7ee_6c9c3fcf3bccd964458e2"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ehxEyezWzaEhLPfY8YzI-_2cc7o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2020 22:05:13 -0000

ianswett commented on this pull request.



> @@ -410,8 +410,9 @@ time threshold MUST be set to at least kGranularity.  The time threshold is:
 max(kTimeThreshold * max(smoothed_rtt, latest_rtt), kGranularity)
 ~~~
 
-If packets sent prior to the largest acknowledged packet cannot yet be declared
-lost, then a timer SHOULD be set for the remaining time.
+When an ACK frame is received and unacknowledged packets sent prior to the

This is slightly less correct, because a loss detection timer could be set for one packet, and then it could be declared lost, and then when it is, the timer may be re-armed for the next packet to be declared lost.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3390#pullrequestreview-353335253