Date: Sun, 27 Jan 2019 04:05:01 -0800
From: erickinnear <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab31c1f217e09eaca773f69344ae5c530240090cc892cf000000011865606d92a169ce180d1061@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2370/review/196824474@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2370@github.com>
References: <quicwg/base-drafts/pull/2370@github.com>
Subject: Re: [quicwg/base-drafts] Stronger migration handshake (#2370)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c4d9e6d3ed45_415d3fe66f2d45c04836cf";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ekJhP-Gv27xVphIddCIH4AlAij4>


----==_mimepart_5c4d9e6d3ed45_415d3fe66f2d45c04836cf
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

erickinnear commented on this pull request.



> @@ -1847,6 +1847,11 @@ endpoint migrates to a new address.
 An endpoint MUST NOT initiate connection migration before the handshake is
 finished and the endpoint has 1-RTT keys.  The design of QUIC relies on
 endpoints retaining a stable address for the duration of the handshake.
+Clients MUST NOT initiate connection migration before they are

Just a nit, but this appears to put stricter requirements on the statements made in the previous two sentences, is there any reason not to merge them together? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2370#pullrequestreview-196824474
----==_mimepart_5c4d9e6d3ed45_415d3fe66f2d45c04836cf
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@erickinnear</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2370#discussion_r251233140">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1847,6 +1847,11 @@ endpoint migrates to a new address.
 An endpoint MUST NOT initiate connection migration before the handshake is
 finished and the endpoint has 1-RTT keys.  The design of QUIC relies on
 endpoints retaining a stable address for the duration of the handshake.
+Clients MUST NOT initiate connection migration before they are
</pre>
<p>Just a nit, but this appears to put stricter requirements on the statements made in the previous two sentences, is there any reason not to merge them together?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2370#pullrequestreview-196824474">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq01JuTteRW6zBWGaeNJGI9ev9vqLks5vHZXtgaJpZM4aUhBL">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq37UFy6Tcj-KbdlR-SMSSPt-lTbNks5vHZXtgaJpZM4aUhBL.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@erickinnear commented on #2370"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2370#pullrequestreview-196824474"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2370#pullrequestreview-196824474",
"url": "https://github.com/quicwg/base-drafts/pull/2370#pullrequestreview-196824474",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c4d9e6d3ed45_415d3fe66f2d45c04836cf--