IETF Logo Mail Archive

Re: [quicwg/base-drafts] No more Retransmittable (#1211)

Marten Seemann <notifications@github.com> Thu, 15 March 2018 16:52 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1E06126D73 for <quic-issues@ietfa.amsl.com>; Thu, 15 Mar 2018 09:52:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.605
X-Spam-Level:
X-Spam-Status: No, score=-0.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FiIC-FkXAYD3 for <quic-issues@ietfa.amsl.com>; Thu, 15 Mar 2018 09:52:42 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B43331252BA for <quic-issues@ietf.org>; Thu, 15 Mar 2018 09:52:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=LY2j5PKoztat1FJi4AIQPuQ2vQI=; b=NpPdgnfvgVhrkTyb J9OU1gSDNXXOAT4G2UfjuCDlgwCfu04CeOutlyEZi3Km5575ymL2pGqg+6m+7zzh gLUthYHBJJ6m35VYoSL/uwU/ZbW0yAzs+ZAHx8SKTWHPNvUh9qAheysUT99EMeC0 C6bZwUQzBJp6B48VM1nKdbsSlA8=
Received: by filter0080p1las1.sendgrid.net with SMTP id filter0080p1las1-9585-5AAAA4DA-3 2018-03-15 16:52:42.083716576 +0000 UTC
Received: from smtp.github.com (out-2.smtp.github.com [192.30.252.193]) by ismtpd0047p1mdw1.sendgrid.net (SG) with ESMTP id mw3i-StlQimdaskU6jkkkQ for <quic-issues@ietf.org>; Thu, 15 Mar 2018 16:52:41.779 +0000 (UTC)
Date: Thu, 15 Mar 2018 16:52:42 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab62461c1697fd214e87d2e3851f46b9276d4f396192cf0000000116c266d992a169ce12377d81@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1211/review/104288904@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1211@github.com>
References: <quicwg/base-drafts/pull/1211@github.com>
Subject: Re: [quicwg/base-drafts] No more Retransmittable (#1211)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aaaa4d992dac_15ed2b1e4f058ec42333ca"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2mbw0g7GJnauiNeGsTASLO+7FR/0izTK22J+ tAXjoZfTQgZ957JqXElXjypXtbQVSqp/yXg+/KRMlEESRm4m5jHTy4ilP0Hhpo+R99cGrOvpAFNrzD L9YQWxFNhXa4XNojQ7FIOQyLJzw9JXVoqVcNdKI8TloVyUNZ54xCZbHCy1/SsO94lmA1Ff18NdyE41 U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ekqB4tpI5y4ptNd2IpcKQnzmdZE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Mar 2018 16:52:44 -0000

marten-seemann commented on this pull request.



> @@ -538,9 +539,9 @@ max_ack_delay:
   RTT sample less than min_rtt.
 
 reordering_threshold:
-: The largest delta between the largest acked
-  retransmittable packet and a packet containing retransmittable frames before
-  it's declared lost.
+: The largest packet number gap between the largest acked
+  congestion controlled packet and smaller unacknowledged congestion
+  controlled packet before it is declared lost.

@nibanks You don't even save packets 1 to 3 (in the sent_packets), so when receiving the ACK for 4, you wouldn't even remember that you ever sent them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1211#discussion_r174854612

v2.29.0 | Report a Bug | By Email | System Status