Re: [quicwg/base-drafts] Default settings in HTTP (#2038)

Kazuho Oku <notifications@github.com> Thu, 22 November 2018 03:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 52524130F0A for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 19:35:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PlMV6l24Jk-f for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 19:35:42 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1E573128D09 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 19:35:41 -0800 (PST)
Date: Wed, 21 Nov 2018 19:35:40 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542857740; bh=986YOjg7IoDk1CNyTc+/DEBt14iPmKofKr/TqaewO28=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ECIBJRIcWFtRYHXAMrBrIp+EVR/wA6trFV+yeU0gwbqSq5JjLIygV6yE/vw4h/0R5 S5Rc6/Ks207nIXjGtHiDaZLuT/QNiH5T1g7RAqmcPvmXbjgkct+wcDxkqMwLac/CS+ vW++hCR/nhNGzhYNbOvbQrlCcAcHvIxbH/LilDdo=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd77760898e1d1ff5e9d800459dcc7d907b78815e92cf00000001180de60c92a169ce16d8e664@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2038/review/177495291@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2038@github.com>
References: <quicwg/base-drafts/pull/2038@github.com>
Subject: Re: [quicwg/base-drafts] Default settings in HTTP (#2038)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf6240c8cf70_3b8f3ffca62d45b4284733"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ey9iu2yZSqi4xupvcOFIpqfxQAk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Nov 2018 03:35:44 -0000

kazuho commented on this pull request.

This looks great!!!

I like the PR because the approach provides the most flexibility; a client that wants to wait for SETTINGS can wait. A client that wants to not wait can start sending requests using the default settings parameters, then update as it receives the SETTINGS frame.

Should we state that the QPACK encoder stream MUST NOT be opened if the current value of SETTINGS_HEADER_TABLE_SIZE is zero, and that the decoder stream MUST NOT be opened until the peer opens the encoder stream?

I ask this because avoiding the cost of maintaining unused but open streams would be beneficial for using HTTP/3 on memory constrained devices. I do not think requiring that would be a burden because an endpoint nevertheless needs to wait for the arrival of the SETTINGS frame before starting to send dynamic table entries on the encoder stream. For the decoder stream, implementations can simply create them lazily.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2038#pullrequestreview-177495291