Re: [quicwg/base-drafts] Version validation fields can't move or change (#498)

[janaiyengar <[e-mail]>]

janaiyengar approved this pull request.

LGTM, modulo readability nits.

> @@ -1232,6 +1232,15 @@ client MUST terminate with a VERSION_NEGOTIATION_ERROR error code if
 version negotiation occurred but it would have selected a different version
 based on the value of the supported_versions list.
 
+When an endpoint accepts multiple QUIC versions, it can potentially interpret
+transport parameters as they are defined by any of the QUIC versions it
+supports.  The version field in the QUIC packet header are only authenticated

nit: are -> is
also, "is only authenticated using" -> "is authenticated using"

> @@ -1232,6 +1232,15 @@ client MUST terminate with a VERSION_NEGOTIATION_ERROR error code if
 version negotiation occurred but it would have selected a different version
 based on the value of the supported_versions list.
 
+When an endpoint accepts multiple QUIC versions, it can potentially interpret
+transport parameters as they are defined by any of the QUIC versions it
+supports.  The version field in the QUIC packet header are only authenticated
+using the transport parameters.  The position and the format of the version
+fields in transport parameters MUST either be identical across different QUIC
+versions, or be unambiguously different in a way that ensures that there is no
+possibility for confusion about their interpretation.  One way that a new format

suggested rephrase: "be unambiguously different in a way that ensures that there is no possibility for confusion about their interpretation" --> "be unambiguously different to ensure no confusion about their interpretation"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/498#pullrequestreview-55410295