Date: Wed, 23 Oct 2019 18:26:45 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK7JSKHGNXY3W6USYGF3XY7GLEVBNHHB47Q2W4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3138/review/306274593@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3138@github.com>
References: <quicwg/base-drafts/pull/3138@github.com>
Subject: Re: [quicwg/base-drafts] Applications need to disable or selectively
 reject 0-RTT (#3138)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5db0fdd51aeeb_616b3f9d70ccd95c246863";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/f1FwEL6G9kQPklAHuPsR9Wrqpts>


----==_mimepart_5db0fdd51aeeb_616b3f9d70ccd95c246863
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.

Some more comments

> @@ -1159,7 +1159,7 @@ the operations described in this section on a QUIC connection.
 When implementing the client role, applications need to be able to:
 
 - open a connection, which begins the exchange described in {{handshake}};
-- enable 0-RTT; and
+- disable or selectively reject 0-RTT; and

A client doesn't receive 0-RTT, so how would it reject it?

The way I think of it is:
"be informed when 0-RTT keys are available."
"be informed when 1-RTT keys are available."

I don't think the client application needs to know if 0-RTT is rejected or accepted, as long as the handshake succeeds?  And applications like HTTP/3 don't want to enable 0-RTT, but only send some data with 0-RTT keys.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3138#pullrequestreview-306274593
----==_mimepart_5db0fdd51aeeb_616b3f9d70ccd95c246863
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<p>Some more comments</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3138#discussion_r338346010">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1159,7 +1159,7 @@ the operations described in this section on a QUIC connection.
 When implementing the client role, applications need to be able to:
 
 - open a connection, which begins the exchange described in {{handshake}};
-- enable 0-RTT; and
+- disable or selectively reject 0-RTT; and
</pre>
<p>A client doesn't receive 0-RTT, so how would it reject it?</p>
<p>The way I think of it is:<br>
"be informed when 0-RTT keys are available."<br>
"be informed when 1-RTT keys are available."</p>
<p>I don't think the client application needs to know if 0-RTT is rejected or accepted, as long as the handshake succeeds?  And applications like HTTP/3 don't want to enable 0-RTT, but only send some data with 0-RTT keys.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3138?email_source=notifications&amp;email_token=AFTOJK2GX4VD4RB7FIZZUKLQQD2VLA5CNFSM4JEKUMCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJAWCII#pullrequestreview-306274593">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK2WM2ZBGVYF7ZHFCY3QQD2VLANCNFSM4JEKUMCA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK6FWKN3EBLC5BZKYLTQQD2VLA5CNFSM4JEKUMCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJAWCII.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3138?email_source=notifications\u0026email_token=AFTOJK2GX4VD4RB7FIZZUKLQQD2VLA5CNFSM4JEKUMCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJAWCII#pullrequestreview-306274593",
"url": "https://github.com/quicwg/base-drafts/pull/3138?email_source=notifications\u0026email_token=AFTOJK2GX4VD4RB7FIZZUKLQQD2VLA5CNFSM4JEKUMCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJAWCII#pullrequestreview-306274593",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5db0fdd51aeeb_616b3f9d70ccd95c246863--