IETF Logo Mail Archive

Re: [quicwg/base-drafts] RFC Editor Copyedits (PR #4956)

Lucas Pardue <notifications@github.com> Tue, 15 February 2022 21:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 165F53A076E for <quic-issues@ietfa.amsl.com>; Tue, 15 Feb 2022 13:01:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.045
X-Spam-Level:
X-Spam-Status: No, score=-7.045 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.576, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s5vofAFvNSrd for <quic-issues@ietfa.amsl.com>; Tue, 15 Feb 2022 13:01:10 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 45EBE3A073E for <quic-issues@ietf.org>; Tue, 15 Feb 2022 13:01:10 -0800 (PST)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id 23D2D600942 for <quic-issues@ietf.org>; Tue, 15 Feb 2022 13:01:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1644958869; bh=2mu6/4uhh41HYaplG/F86hxj+bdwGrbqHfg1A1QKEhU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VrHOOCTVVxrlSBz8coWVivXbQglmDyi31H+CvE9Sgpdiz36/WiPj+UyuIvXB6K53n sWzsh780XlvWWPaso+7FQ20gu6FWKJ1HEiKssubwiA0d5FwrgOH0r5ZyWPK8wNXFej p36Puzg5vkXNx55ljw6PyyTHh5dj7D6MgVQWLSAk=
Date: Tue, 15 Feb 2022 13:01:09 -0800
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYCNBQE52Z2N3KV276AC72ZLEVBNHHEHZVETM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4956/review/883644224@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4956@github.com>
References: <quicwg/base-drafts/pull/4956@github.com>
Subject: Re: [quicwg/base-drafts] RFC Editor Copyedits (PR #4956)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_620c14951464c_57f7c6fc3427937"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/f4DuUQXEU4hVUutZ8Km0kkgybvc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Feb 2022 21:01:13 -0000

@LPardue commented on this pull request.



>  implementation can decide to close a QUIC stream and communicate the type of
 error. Wire encodings of error codes are defined in {{http-error-codes}}.
-Stream errors are distinct from HTTP status codes which indicate error
+Stream errors are distinct from HTTP status codes that indicate error

I agree the `, which` variant breaks the intention of this sentence.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4956#discussion_r807310971
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4956/review/883644224@github.com>

v2.8.7 | Report a Bug | By Email