IETF Logo Mail Archive

Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)

Dmitri Tikhonov <notifications@github.com> Fri, 28 September 2018 13:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CA2912785F for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 06:14:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.456
X-Spam-Level:
X-Spam-Status: No, score=-3.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o3_KnYvU7Q-i for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 06:14:57 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 413C4124BE5 for <quic-issues@ietf.org>; Fri, 28 Sep 2018 06:14:57 -0700 (PDT)
Date: Fri, 28 Sep 2018 06:14:56 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538140496; bh=X97T5wvNX0EmyDdYDc6JY1nbBJ+vlIklpogz7fovJJw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jV0ijmFuVz3p22kdfVjkyRN3n8vBoczoU/2EIa4DoTdiNfT8Z68iFSV62KZ4J5BBP 7e52jHHu6Ktkujvv+PJ90B8WlJPGy3DO9Sr2laelHiGlulLxAA4akyRsZwkuFTWh8u MxNNyXSugqBKGzeRvK5UjpJToMGYpmOqVE3/hQHA=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1e3dc27f4f1bcc3778987d822a58616038df865492cf0000000117c5eb5092a169ce1586350b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1763/review/159853454@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1763@github.com>
References: <quicwg/base-drafts/pull/1763@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bae295046573_1643f97f20d45c088592"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fQWVAQGLY2XItrzdXv6piBHvZXE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2018 13:14:59 -0000

dtikhonov commented on this pull request.



> +### Calculating Table Size
+
+The size of the dynamic table is the sum of the size of its entries.
+
+The size of an entry is the sum of its name's length in octets (as defined in
+{{string-literals}}), its value's length in octets, and 32.
+
+The size of an entry is calculated using the length of its name and value
+without any Huffman encoding applied.
+
+`MaxEntries` is the maximum number of entries that the dynamic table can have.
+The smallest entry has empty name and value strings and has the size of 32.
+The MaxEntries is calculated as
+
+~~~
+   MaxEntries = floor( MaxTableSize / 32 )

Why would it be `ceil`?  Integer division calls for `floor`.  What kind of edge cases do you mean, @MikeBishop?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1763#discussion_r221247967

v2.30.2 | Report a Bug | By Email | System Status