Date: Mon, 10 Jun 2019 19:32:44 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKYYKZTIMPHT2ZVN7CN3BRCUZEVBNHHBWCV3SI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2776/review/247927367@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2776@github.com>
References: <quicwg/base-drafts/pull/2776@github.com>
Subject: Re: [quicwg/base-drafts] Explain initial settings a little more
 (#2776)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5cff12cc30b1c_1f493fa8094cd95c116212";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fbqiFRjAcqR9uMSAilQLhA20cd0>


----==_mimepart_5cff12cc30b1c_1f493fa8094cd95c116212
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett approved this pull request.



> @@ -1340,7 +1340,9 @@ setting is the default value. When a 0-RTT QUIC connection is being used, the
 initial value of each server setting is the value used in the previous session.
 Clients MUST store the settings the server provided in the session being resumed
 and MUST comply with stored settings until the current server settings are
-received.
+received.  A client uses these initial values in a situation where it wants to

```suggestion
received.  A client uses these initial values in situations where it wants to
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2776#pullrequestreview-247927367
----==_mimepart_5cff12cc30b1c_1f493fa8094cd95c116212
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@ianswett</b> approved this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/2776#discussi=
on_r292257900">draft-ietf-quic-http.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -1340,7 +1340,9 @@ setting is the defau=
lt value. When a 0-RTT QUIC connection is being used, the=0D
 initial value of each server setting is the value used in the previous s=
ession.=0D
 Clients MUST store the settings the server provided in the session being=
 resumed=0D
 and MUST comply with stored settings until the current server settings a=
re=0D
-received.=0D
+received.  A client uses these initial values in a situation where it wa=
nts to=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-received.  A client uses these initial values=
 in a situation where it wants to=0D
+received.  A client uses these initial values in situations where it wan=
ts to=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/2776?email_source=3Dnotifications&amp;email_token=3DA=
FTOJK5CZHUSFEDOAXT37KDPZ4FEZA5CNFSM4HV2GMMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3DRERY#pullrequestreview-247927367=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK7XUGN6RMHXJAAOHU3PZ4FEZANCNFSM4HV2GMMA">mute the th=
read</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK3BTLHP=
5XT5RQZKIODPZ4FEZA5CNFSM4HV2GMMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FE=
ZLWNFSXPKTDN5WW2ZLOORPWSZGOB3DRERY.gif" height=3D"1" width=3D"1" alt=3D""=
 /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/2776?email_source=3D=
notifications\u0026email_token=3DAFTOJK5CZHUSFEDOAXT37KDPZ4FEZA5CNFSM4HV2=
GMMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB=
3DRERY#pullrequestreview-247927367",=0D
"url": "https://github.com/quicwg/base-drafts/pull/2776?email_source=3Dno=
tifications\u0026email_token=3DAFTOJK5CZHUSFEDOAXT37KDPZ4FEZA5CNFSM4HV2GM=
MKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3D=
RERY#pullrequestreview-247927367",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5cff12cc30b1c_1f493fa8094cd95c116212--