Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)

Martin Thomson <notifications@github.com> Mon, 20 April 2020 09:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F326D3A0967 for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 02:53:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.2
X-Spam-Level:
X-Spam-Status: No, score=-1.2 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q5zHQzpZaZUI for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 02:53:40 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 44DAE3A08EE for <quic-issues@ietf.org>; Mon, 20 Apr 2020 02:53:40 -0700 (PDT)
Received: from github-lowworker-cf59896.ash1-iad.github.net (github-lowworker-cf59896.ash1-iad.github.net [10.56.112.26]) by smtp.github.com (Postfix) with ESMTP id 670451C1892 for <quic-issues@ietf.org>; Mon, 20 Apr 2020 02:53:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1587376419; bh=RxM+4aYQ9R97xN/3qNs1Say3rCyaSswH/n1dRhNMJL8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eFDqefwse1ZnJMCpOsUmCWM+sV6yy0jCRazEb1/I9ULzaNx6lZhN2bdSB4s/HUEth XyvNjSSfe9y4nPz46ZgqfI4zcr9EKm8ez4zHrCcXFSVl+r4v1TfUlZplq5Xxp7HCdA vx1OLZck3IFg+WOZ/QHBVZSo/swUb9VbhS1S+8Ho=
Date: Mon, 20 Apr 2020 02:53:39 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7BHJ47I35MYTGSGJF4VFJCHEVBNHHCH4LVNY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3589/review/396301600@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3589@github.com>
References: <quicwg/base-drafts/pull/3589@github.com>
Subject: Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e9d7123592b0_556a3fc7b44cd96436018c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fca9uz0rQWEWQU3lxym-5Hf2ntk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Apr 2020 09:53:42 -0000

@martinthomson commented on this pull request.

Thanks for putting this together.

I have a few editorial comments, which look worse than they really are.

> +Similarly, an endpoint MUST NOT reuse a connection ID when sending to more than
+one destination address, for example when responding to a change in the address
+of a peer if the packet with the new peer address uses an active connection ID
+that has not been previously used by the peer.

This is a little long and the 'for example' is a little buried.

```suggestion
Similarly, an endpoint MUST NOT reuse a connection ID when sending to a remote
address from which the peer has chosen to use a connection ID that has not
previously been used.  This occurs when an endpoint receives packets that
include a change to both the source address and destination connection ID at the
same time.
```

> +Note that these requirements apply to the endpoints sending packets, as
+unintentional changes in path without a change in connection ID are possible.
+For example, after a period of network inactivity, NAT rebinding might cause
+packets to be sent on a new path when the client resumes sending.  An endpoint
+responds to such an event as described in {{migration-response}}.

```suggestion
These requirements regarding connection ID reuse apply only to the sending of
packets, as unintentional changes in path without a change in connection ID are
possible.  For example, after a period of network inactivity, NAT rebinding
might cause packets to be sent on a new path when the client resumes sending.
An endpoint responds to such an event as described in {{migration-response}}.
```

>  : The sequence number of the connection ID being retired.  See
-  {{retiring-cids}}.
+  {{retire-cid}}.

I can't suggest here (damn GitHub).  But what you want is a semi-colon: '; see {{retire-cid}}.'

> @@ -5610,7 +5619,7 @@ IDs, the endpoint MAY treat that receipt as a connection error of type
 PROTOCOL_VIOLATION.
 
 The Retire Prior To field counts connection IDs established during connection
-setup and the preferred_address transport parameter (see {{retiring-cids}}). The
+setup and the preferred_address transport parameter (see {{retire-cid}}). The

```suggestion
setup and the preferred_address transport parameter; see {{retire-cid}}. The
```

>  : A variable-length integer indicating which connection IDs should be retired.
-  See {{retiring-cids}}.
+  See {{retire-cid}}.

semi-colon here too.

>  {{migrate-validate}}) of that address using the connection ID provided in the
-preferred_address transport parameter.
+preferred_address transport parameter or, if that connection ID has been
+retired, any active connection ID that has not already been used on a different
+path.

I can't suggest here, but maybe "using any previously unused connection ID, taken from either the preferred_address transport parameter or the NEW_CONNECTION_ID frame."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3589#pullrequestreview-396301600