Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)

[Martin Thomson <[e-mail]>]

@martinthomson commented on this pull request.

Thanks for putting this together.

I have a few editorial comments, which look worse than they really are.

> +Similarly, an endpoint MUST NOT reuse a connection ID when sending to more than
+one destination address, for example when responding to a change in the address
+of a peer if the packet with the new peer address uses an active connection ID
+that has not been previously used by the peer.

This is a little long and the 'for example' is a little buried.

```suggestion
Similarly, an endpoint MUST NOT reuse a connection ID when sending to a remote
address from which the peer has chosen to use a connection ID that has not
previously been used.  This occurs when an endpoint receives packets that
include a change to both the source address and destination connection ID at the
same time.
```

> +Note that these requirements apply to the endpoints sending packets, as
+unintentional changes in path without a change in connection ID are possible.
+For example, after a period of network inactivity, NAT rebinding might cause
+packets to be sent on a new path when the client resumes sending.  An endpoint
+responds to such an event as described in {{migration-response}}.

```suggestion
These requirements regarding connection ID reuse apply only to the sending of
packets, as unintentional changes in path without a change in connection ID are
possible.  For example, after a period of network inactivity, NAT rebinding
might cause packets to be sent on a new path when the client resumes sending.
An endpoint responds to such an event as described in {{migration-response}}.
```

>  : The sequence number of the connection ID being retired.  See
-  {{retiring-cids}}.
+  {{retire-cid}}.

I can't suggest here (damn GitHub).  But what you want is a semi-colon: '; see {{retire-cid}}.'

> @@ -5610,7 +5619,7 @@ IDs, the endpoint MAY treat that receipt as a connection error of type
 PROTOCOL_VIOLATION.
 
 The Retire Prior To field counts connection IDs established during connection
-setup and the preferred_address transport parameter (see {{retiring-cids}}). The
+setup and the preferred_address transport parameter (see {{retire-cid}}). The

```suggestion
setup and the preferred_address transport parameter; see {{retire-cid}}. The
```

>  : A variable-length integer indicating which connection IDs should be retired.
-  See {{retiring-cids}}.
+  See {{retire-cid}}.

semi-colon here too.

>  {{migrate-validate}}) of that address using the connection ID provided in the
-preferred_address transport parameter.
+preferred_address transport parameter or, if that connection ID has been
+retired, any active connection ID that has not already been used on a different
+path.

I can't suggest here, but maybe "using any previously unused connection ID, taken from either the preferred_address transport parameter or the NEW_CONNECTION_ID frame."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3589#pullrequestreview-396301600