IETF Logo Mail Archive

Re: [quicwg/base-drafts] Execute the PTO alarm immediately if in the past (#4831)

Lars Eggert <notifications@github.com> Wed, 24 February 2021 09:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5925C3A12A7 for <quic-issues@ietfa.amsl.com>; Wed, 24 Feb 2021 01:32:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.052
X-Spam-Level:
X-Spam-Status: No, score=-2.052 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xqqe39TDr1f1 for <quic-issues@ietfa.amsl.com>; Wed, 24 Feb 2021 01:32:35 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 04F983A12A5 for <quic-issues@ietf.org>; Wed, 24 Feb 2021 01:32:35 -0800 (PST)
Received: from github.com (hubbernetes-node-b3e07bb.va3-iad.github.net [10.48.112.54]) by smtp.github.com (Postfix) with ESMTPA id 3FF12E05AB for <quic-issues@ietf.org>; Wed, 24 Feb 2021 01:32:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1614159154; bh=luFM/GylIoy7eIkTG40viSDkVoRvA/ebXS2YpkPQdCk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DUO16h8SFcNmTWbOjf0DmBogK9MdcH/J6y9mR3JskwIAGxCII1baFPN8m6QTYQE9q 7hvY0pqbL0634Xnpy01sddTnNKi/6jAWEMKupVrgk5VwHnDIhgFTLlTOpBxx7nrmRX N27zD6ZwLVaLOhHbUL4I5TmaECxe2sBF6+QsMF0c=
Date: Wed, 24 Feb 2021 01:32:34 -0800
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ZAJ2G7PRJS7OIPP56IH7DFEVBNHHDBDTNMQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4831/review/597272540@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4831@github.com>
References: <quicwg/base-drafts/pull/4831@github.com>
Subject: Re: [quicwg/base-drafts] Execute the PTO alarm immediately if in the past (#4831)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_60361d323d471_4a1a542090e4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: larseggert
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fjG3e2jb1SIcH8d5P8-cRftvzys>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2021 09:32:36 -0000

@larseggert commented on this pull request.



> @@ -664,8 +664,11 @@ data it can send is limited to three times the amount of data received,
 as specified in {{Section 8.1 of QUIC-TRANSPORT}}. If no additional data can be
 sent, the server's PTO timer MUST NOT be armed until datagrams have been
 received from the client, because packets sent on PTO count against the
-anti-amplification limit. Note that the server could fail to validate the
-client's address even if 0-RTT is accepted.
+anti-amplification limit.  The server's PTO timer could be re-armed to a time
+in the past after being amplification limited, in which case it is executed
+immediately. Doing so avoids sending new packets in ApplicationData prior to

`ApplicationData` is so far only used in the pseudo code. Can we rephrase this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4831#pullrequestreview-597272540

v2.23.0 | Report a Bug | By Email