IETF Logo Mail Archive

Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)

MikkelFJ <notifications@github.com> Thu, 17 January 2019 20:24 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4158A130FBA for <quic-issues@ietfa.amsl.com>; Thu, 17 Jan 2019 12:24:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.552
X-Spam-Level:
X-Spam-Status: No, score=-7.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U7WfBEf1-2bS for <quic-issues@ietfa.amsl.com>; Thu, 17 Jan 2019 12:23:59 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 10AB9130FB5 for <quic-issues@ietf.org>; Thu, 17 Jan 2019 12:23:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=kEcwh7FEmdae6NEIdnzShysmnBk=; b=qmUL+Ft2KhrhCApw Ava2WH3wu3QtkcncriM/XDzE76hpNqF9kokZDzOyEny4qji/j0E+dHvVMBWKyGqS MZEYcevlQ6EZHyy3SlMznW5vFEApVba7LgQ1qnqm3yqP6oGQL5LRibOqy8lDZl7Q d/eVxp+cpHTWi/jfml3wSaGtVrE=
Received: by filter0163p1iad2.sendgrid.net with SMTP id filter0163p1iad2-9953-5C40E45D-E 2019-01-17 20:23:57.844108016 +0000 UTC m=+250071.801737936
Received: from github-lowworker-fc273f0.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0050p1iad1.sendgrid.net (SG) with ESMTP id pIgzht0sRX68a6aF1uPdAA for <quic-issues@ietf.org>; Thu, 17 Jan 2019 20:23:57.834 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-fc273f0.cp1-iad.github.net (Postfix) with ESMTP id C9F7FC0B3D for <quic-issues@ietf.org>; Thu, 17 Jan 2019 12:23:57 -0800 (PST)
Date: Thu, 17 Jan 2019 20:23:57 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab384fc20271075e2bc9c2db2eb4e5fa950fe739ac92cf000000011858a65d92a169ce179e43e2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2299/455319128@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2299@github.com>
References: <quicwg/base-drafts/issues/2299@github.com>
Subject: Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c40e45dc8acd_5be53fd1de4d45b44392d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak108O/WFTH2TRjTzzM81KqM44ECenp41pY20r SwTjAiQgMMAU5bA1RX63iL6vqWKlK5j6IKx5ZeYlzXD8Ng2zVJT2owPwI4BJ59NdIsRTEw0WIuPOen QK5VwPNUVN3E6Pb8KxpfvYxhU8tr21F160ssHo70S6AzW2R9DoZfCdsX0Q==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fob-fh6uIFlmMcqw5Yo5e-4WVM0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2019 20:24:06 -0000

Honestly, if it is _only_ about long headers length field, then by all means make it canonical. There are so few of those packages, and memmove is relatively cheap, especially compared to the handshake. Furthermore, you can special case those packets to start at an offset and move the preceding data down, or even write them after the length. Typically you can even with benefit use a vectored write with a separate buffer for the header. And for higher level languages that care less about performance, you can just concatenate two buffers.

If it were post handshake with lots of data it would be different. This hangs on ACK's being easy to generate with known lengths.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2299#issuecomment-455319128

v2.46.0 | Report a Bug | By Email | System Status