Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 80C253A097E
 for <quic-issues@ietfa.amsl.com>; Thu,  7 May 2020 16:45:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.694
X-Spam-Level: 
X-Spam-Status: No, score=-1.694 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ZfRW_h0jtKUK for <quic-issues@ietfa.amsl.com>;
 Thu,  7 May 2020 16:45:33 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 71C263A097A
 for <quic-issues@ietf.org>; Thu,  7 May 2020 16:45:33 -0700 (PDT)
Received: from github-lowworker-b2150d3.ash1-iad.github.net
 (github-lowworker-b2150d3.ash1-iad.github.net [10.56.113.12])
 by smtp.github.com (Postfix) with ESMTP id 4272F8C0F31
 for <quic-issues@ietf.org>; Thu,  7 May 2020 16:45:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1588895132;
 bh=fTXTV2vBNEqSyvfij8/zUVjyGVRDfv5EL1RJxeBGzdk=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=cvj+x0LnrAYdKj5eoStoQIsqpg2/DJk1oCWYW4mjWX5+84f1WoW6dYiHGLQfMMfGd
 mYwkGTda9Q4iDGeaQJOhYZekyyiMRHFEzwkYJ9WFyG6PaaVSliPbIPuq9CUMwE4jO1
 rpVXRFsAUEz7Voe4Eh/Y6YfLpYge97bGcoy+oJb0=
Date: Thu, 07 May 2020 16:45:32 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK6U4WAPNXCHI5GY4754YB7JZEVBNHHCJHOYRM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3636/review/407908579@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3636@github.com>
References: <quicwg/base-drafts/pull/3636@github.com>
Subject: Re: [quicwg/base-drafts] Text/figure consistency (#3636)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5eb49d9c314ca_22d53f83862cd9601193b2";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fr-ioZw9U1jbCdIB1vEocKVOJyo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 May 2020 23:45:38 -0000


----==_mimepart_5eb49d9c314ca_22d53f83862cd9601193b2
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@martinthomson requested changes on this pull request.



> @@ -138,9 +138,9 @@ Long Header Packet {
   Version-Specific Bits (7),
   Version (32),
   DCID Len (8),
-  Destination Connection ID (0..160),
+  Destination Connection ID (0..255),

Yikes, we both got this wrong.  (And then I got it wrong again by putting 2047 here first.)

```suggestion
  Destination Connection ID (0..2040),
```

>    SCID Len (8),
-  Source Connection ID (0..160),
+  Source Connection ID (0..255),

```suggestion
  Source Connection ID (0..2040),
```

> @@ -138,9 +138,9 @@ Long Header Packet {
   Version-Specific Bits (7),

^^ Up there, there is a redundant sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3636#pullrequestreview-407908579
----==_mimepart_5eb49d9c314ca_22d53f83862cd9601193b2
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p></p>=0D
<p><b>@martinthomson</b> requested changes on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3636#discussi=
on_r421855643">draft-ietf-quic-invariants.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -138,9 +138,9 @@ Long Header Packet {=0D=

   Version-Specific Bits (7),=0D
   Version (32),=0D
   DCID Len (8),=0D
-  Destination Connection ID (0..160),=0D
+  Destination Connection ID (0..255),=0D
</pre>=0D
<p>Yikes, we both got this wrong.  (And then I got it wrong again by putt=
ing 2047 here first.)</p>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-  Destination Connection ID (0..255),=0D
+  Destination Connection ID (0..2040),=0D
</pre>=0D
=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3636#discussi=
on_r421855679">draft-ietf-quic-invariants.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt;    SCID Len (8),=0D
-  Source Connection ID (0..160),=0D
+  Source Connection ID (0..255),=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-  Source Connection ID (0..255),=0D
+  Source Connection ID (0..2040),=0D
</pre>=0D
=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3636#discussi=
on_r421856326">draft-ietf-quic-invariants.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -138,9 +138,9 @@ Long Header Packet {=0D=

   Version-Specific Bits (7),=0D
</pre>=0D
<p>^^ Up there, there is a redundant sentence.</p>=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3636#pullrequestreview-407908579">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AFTOJ=
K3FPDEEKPM5THOVNWDRQNBZZANCNFSM4M3UJ73Q">unsubscribe</a>.<img src=3D"http=
s://github.com/notifications/beacon/AFTOJKYBMKXSHYSFO3B4XBTRQNBZZA5CNFSM4=
M3UJ732YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZ=
GODBIDBYY.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3636#pullrequestrev=
iew-407908579",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3636#pullrequestreview=
-407908579",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5eb49d9c314ca_22d53f83862cd9601193b2--