Re: [quicwg/base-drafts] Servers should always send CANCEL_PUSH (#3700)

Martin Thomson <notifications@github.com> Thu, 28 May 2020 01:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 512CD3A07C3 for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 18:16:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NHuZ39OdYvHZ for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 18:16:16 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D77533A07BF for <quic-issues@ietf.org>; Wed, 27 May 2020 18:16:15 -0700 (PDT)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id E34EF8C0349 for <quic-issues@ietf.org>; Wed, 27 May 2020 18:16:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590628574; bh=L7xgmlMETmqDBIbQysLz6wNGR4vXkPy9dX0edFXiuV0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cxGMjUjmKeB9/E+8RtD5Z3ZYPSlzRvTdOkSaga14LL6Zrn9INMz5CZmfdTwcTrM6u gjnVjyP0P4AD72j580ZwJpgBmrpS+aZEKLlJ/h3dij69/KTAQF1SiOvviwzYZb2yTm cF6rwxNnVvBURm4y+Plc5RZEO3JtF8ieqKr/NAAA=
Date: Wed, 27 May 2020 18:16:14 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3MKQREF7JUX5QT5RN43LY55EVBNHHCKREEAQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3700/review/419713612@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3700@github.com>
References: <quicwg/base-drafts/pull/3700@github.com>
Subject: Re: [quicwg/base-drafts] Servers should always send CANCEL_PUSH (#3700)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ecf10ded4a6a_6f5d3fc984ccd96c1041fa"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ftIf6t6UiqHnR6mYEdCT9LZu0OM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2020 01:16:17 -0000

@martinthomson approved this pull request.



> @@ -1292,9 +1292,10 @@ SHOULD send a CANCEL_PUSH even if it has opened the corresponding stream.
 
 Sending CANCEL_PUSH has no direct effect on the state of existing push streams.
 A client SHOULD NOT send a CANCEL_PUSH when it has already received a
-corresponding push stream.  If a push stream arrives after a client has sent
-CANCEL_PUSH, this MAY be treated as a stream error of type
-H3_STREAM_CREATION_ERROR.
+corresponding push stream.  A push stream may arrive after a client has sent

```suggestion
corresponding push stream.  A push stream could arrive after a client has sent
```

> @@ -1292,9 +1292,10 @@ SHOULD send a CANCEL_PUSH even if it has opened the corresponding stream.
 
 Sending CANCEL_PUSH has no direct effect on the state of existing push streams.
 A client SHOULD NOT send a CANCEL_PUSH when it has already received a
-corresponding push stream.  If a push stream arrives after a client has sent
-CANCEL_PUSH, this MAY be treated as a stream error of type
-H3_STREAM_CREATION_ERROR.
+corresponding push stream.  A push stream may arrive after a client has sent
+CANCEL_PUSH, because a server may have not yet processed the CANCEL_PUSH. The

```suggestion
CANCEL_PUSH, because a server might not have processed the CANCEL_PUSH. The
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3700#pullrequestreview-419713612