IETF Logo Mail Archive

[quicwg/base-drafts] Fixing recovery pseudocode (#3909)

Kazu Yamamoto <notifications@github.com> Wed, 15 July 2020 00:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF2A13A094F for <quic-issues@ietfa.amsl.com>; Tue, 14 Jul 2020 17:16:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.715
X-Spam-Level:
X-Spam-Status: No, score=-1.715 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FFWwCnAq4Sp2 for <quic-issues@ietfa.amsl.com>; Tue, 14 Jul 2020 17:16:42 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AA41F3A08B1 for <quic-issues@ietf.org>; Tue, 14 Jul 2020 17:16:42 -0700 (PDT)
Received: from github-lowworker-e8b54ca.ac4-iad.github.net (github-lowworker-e8b54ca.ac4-iad.github.net [10.52.23.39]) by smtp.github.com (Postfix) with ESMTP id 39CA62612C8 for <quic-issues@ietf.org>; Tue, 14 Jul 2020 17:16:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594772202; bh=sapSqKfDh+fVxh70cHc7h+N5lTb8fqEkChUt7Z9DfjI=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=LCGta9aDfZi/e54byDDOIsoEJ0re4CE7P9VNiPNA6rPLg9mOhdekaditqzNiU8oZD YSwjyfyh9zAcChfCye4r5u9vdHaA4I8Ax+wQ8BVvrOsfefX8ahycwSWCRFL1bpcOKr tNH569Qnn8yiy7v8vxzuIquHarIBU3o/vnhkqNvI=
Date: Tue, 14 Jul 2020 17:16:41 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6IS7RVFMOURDEYWAN5DIV6TEVBNHHCOKE3XU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3909@github.com>
Subject: [quicwg/base-drafts] Fixing recovery pseudocode (#3909)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0e4ae9e8fd1_1da3fb4134cd96467834"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ftN301dYyg1vCR7V-U_yGIUJbck>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2020 00:16:44 -0000

- Fixing trivial syntax errors.
- Adding comments for unused variables or defined-later.
- 6d43abd changes `return` to `continue` to make sense. (need to check by reviewers)
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3909

-- Commit Summary --

  * now -&gt; now()
  * using &quot;.sent_bytes&quot; instead of undefined &quot;.size&quot;
  * using &quot;continue&quot; instead of &quot;return&quot;.
  * using bytes_in_flight instead of words.
  * adding a comment since bytes_in_flight is not defined here yet.
  * adding comment.

-- File Changes --

    M draft-ietf-quic-recovery.md (24)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/3909.patch
https://github.com/quicwg/base-drafts/pull/3909.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3909

v2.28.0 | Report a Bug | By Email | System Status