IETF Logo Mail Archive

Re: [quicwg/base-drafts] Change error codes from 16-bit to varints (#2680)

Mike Bishop <notifications@github.com> Fri, 10 May 2019 19:44 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D8931200C1 for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 12:44:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.464
X-Spam-Level:
X-Spam-Status: No, score=-1.464 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FbCHmhkaVlB0 for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 12:44:43 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 978191200B9 for <quic-issues@ietf.org>; Fri, 10 May 2019 12:44:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=q077b2tLRj2QQlZGC0iabe6TpFc=; b=bvWdd4gQXCz5/Rrn ZhX4lANwotdrPKjsweAB0W2aLCW/jJ17I3jgsQ6dPlwVrKluAv+fhw3pQbdF5uHL /sAyboMz9xGhwrAFxDRc4dPRsihfQ/o3OYZa1HOGasaFbN7fR1z9asGBCjJiClaG kTz3xgCprVES4QvI+1Iol5Y24PQ=
Received: by filter1616p1mdw1.sendgrid.net with SMTP id filter1616p1mdw1-5687-5CD5D4A9-26 2019-05-10 19:44:41.845206273 +0000 UTC m=+165624.498099229
Received: from github-lowworker-e8fa9ff.cp1-iad.github.net (unknown [140.82.115.65]) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id u75lJeHGTpengKLqJvVE4A for <quic-issues@ietf.org>; Fri, 10 May 2019 19:44:41.805 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e8fa9ff.cp1-iad.github.net (Postfix) with ESMTP id B96B8420253 for <quic-issues@ietf.org>; Fri, 10 May 2019 12:44:41 -0700 (PDT)
Date: Fri, 10 May 2019 19:44:42 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7XQOLKLOOIFOZNSVN24MDSTEVBNHHBUXBX44@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2680/review/236282613@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2680@github.com>
References: <quicwg/base-drafts/pull/2680@github.com>
Subject: Re: [quicwg/base-drafts] Change error codes from 16-bit to varints (#2680)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd5d4a9b721d_71e43f8c5cccd9683504d6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3FVxRvdVIqbgvVLG+SmLp+W83qlL8O1i3NQW vQTh0DZYAYZ+kZN4+1+OdrcBe57xPrYI6sQ0SquZNqxODdoPNBrCTPea+IsQPgboMK6D6nAEilEdbQ btvk4KajQ8NRchnPJpoQ/NWV7Ac+kxlt94aP6Xox5BY7IEdrxF1ctYGUWdXKItdkGtc4hMbThLBl2H c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fwFIzWrfKjvpT_BiXoUdRvLMuP8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2019 19:44:46 -0000

MikeBishop commented on this pull request.



>  
 Registrations MUST include the following fields:
 
 Value:
 
 : The numeric value of the assignment (registrations will be between 0x0000 and
-  0xfeff).
+  0x3fff).

Actually, you had it right, because the range is subdivided above in the text you also borrowed from Frame Types.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2680#discussion_r283019638

v2.23.0 | Report a Bug | By Email