Re: [quicwg/base-drafts] Small clarification and one nit (recovery) (#3392)

mirjak <notifications@github.com> Thu, 23 January 2020 13:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E938712008D for <quic-issues@ietfa.amsl.com>; Thu, 23 Jan 2020 05:52:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rn8Y7CrCXhqC for <quic-issues@ietfa.amsl.com>; Thu, 23 Jan 2020 05:52:22 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 79C7A120025 for <quic-issues@ietf.org>; Thu, 23 Jan 2020 05:52:22 -0800 (PST)
Date: Thu, 23 Jan 2020 05:52:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579787541; bh=F0gEH9CWBSwDQk5P030B/1ChS7zKjlE5SnEYj1FCF+4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WgNwuvotzC6ZodeXe4vWEEweBTOB8BtZ2s+E3kOXwEhmxxo6bjX186E5w0gx+UVnQ ErmxqHPxHMsigid/4WsdGTxme2x5bxWfdcWEd9cg0h+EXTeKh2zbzanLdgth+9NB+4 3UgqulWwzE7Z0r/uK61gC3Wv8ksWTn9KR8LPcbHw=
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6KFMDEHHDBI7P2A5N4G3LZLEVBNHHCCBYAVY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3392/review/347309634@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3392@github.com>
References: <quicwg/base-drafts/pull/3392@github.com>
Subject: Re: [quicwg/base-drafts] Small clarification and one nit (recovery) (#3392)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e29a51593836_2ccc3fb0968cd968281434"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fxpCfFz9K-xj62oJVRcWn4ZMK8I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jan 2020 13:52:24 -0000

mirjak commented on this pull request.



> @@ -467,14 +467,14 @@ Handshake packet number spaces, the max_ack_delay is 0, as specified in
 The PTO value MUST be set to at least kGranularity, to avoid the timer expiring
 immediately.
 
-A sender computes its PTO timer every time an ack-eliciting packet is sent.
+A sender resets its PTO timer every time an ack-eliciting packet is sent.

On a quick read it's actually not clear from the beginning that there is only one timer and not a separate timer for each packet. So maybe "recomputes" catches that? Or we could add a separate (half-)sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3392#discussion_r370128036