Re: [quicwg/base-drafts] Simplify receiver verification of ECN counters (#1565)
Martin Thomson <notifications@github.com> Sat, 14 July 2018 21:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3C88130EBD for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 14:34:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pF7GnMi_8Toc for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 14:34:28 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A5D0130DC5 for <quic-issues@ietf.org>; Sat, 14 Jul 2018 14:34:28 -0700 (PDT)
Date: Sat, 14 Jul 2018 14:34:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531604067; bh=qxhOSafF0MxPvbp8dM0s/3401Zd9BhKPJIjv1UKOudI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kOn6iqzB1h0FnAeRJ95muGkGujZAoO1hjk/NU64VLTsx/NGOvttF3TvixRyJNoNp/ ZuCvFNqUc0qW4lojQrS0+VCKzweIIXRecqqNiDJj34eGvkgLV5ztSei1g7WdLb8NIZ jEjg1dpfNeDXKyfyXZvds+AHt+81kRRDrO4CzdWg=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf231106d33b05b4901892881b8f77584f396f92492cf0000000117622e6392a169ce14575bef@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1565/review/137249097@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1565@github.com>
References: <quicwg/base-drafts/pull/1565@github.com>
Subject: Re: [quicwg/base-drafts] Simplify receiver verification of ECN counters (#1565)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4a6c634832b_20f32accd107af5832502c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fzE4R0Zzksri_k8pXk0qjwqvRc8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jul 2018 21:34:32 -0000
martinthomson approved this pull request. > @@ -1771,20 +1772,18 @@ the expectation that either the network or the peer no longer supports ECN. To protect the connection from arbitrary corruption of ECN codepoints by the network, an endpoint verifies the following when an ACK_ECN frame is received: -* The total increase in ECT(0), ECT(1), and CE counters reported in the ACK_ECN - frame MUST be equal to the total number of packets newly acknowledged in this - ACK_ECN frame. - -* The increase in ECT(0) and ECT(1) counters MUST be no greater than the number +* The increase in ECT(0) and ECT(1) counters MUST be no lesser than the number "no lesser" isn't a turn of phrase I'm comfortable with. "MUST be at least the number of newly acknowledged packets" > of packets newly acknowledged that were sent with the corresponding codepoint. -* If the increase in the ECT(0), ECT(1) and CE counters are greater than - the number of newly acknowledged packets, and the received ACK's - smallest acknowledged is larger than the previous largest acknowledged, - then it's likely acknowledgements were missed, and the above comparison - MUST NOT be performed. Instead a new comparison point is stored by the - sender so that only changes after this point will be used in the future - comparisons. +* The total increase in ECT(0), ECT(1), and CE counters reported in the ACK_ECN + frame MUST be no lesser than the total number of packets newly acknowledged in ditto -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1565#pullrequestreview-137249097
- [quicwg/base-drafts] Simplify receiver verificati… janaiyengar
- Re: [quicwg/base-drafts] Simplify receiver verifi… janaiyengar
- Re: [quicwg/base-drafts] Simplify receiver verifi… Martin Thomson
- Re: [quicwg/base-drafts] Simplify receiver verifi… ianswett
- Re: [quicwg/base-drafts] Simplify receiver verifi… Magnus Westerlund
- Re: [quicwg/base-drafts] Simplify receiver verifi… janaiyengar
- Re: [quicwg/base-drafts] Simplify receiver verifi… janaiyengar
- Re: [quicwg/base-drafts] Simplify receiver verifi… janaiyengar