Re: [quicwg/base-drafts] Version validation fields can't move or change (#498)
ianswett <notifications@github.com> Mon, 22 May 2017 19:00 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B87612EBB4 for <quic-issues@ietfa.amsl.com>; Mon, 22 May 2017 12:00:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.616
X-Spam-Level:
X-Spam-Status: No, score=-0.616 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YcnNZUAWc2xt for <quic-issues@ietfa.amsl.com>; Mon, 22 May 2017 12:00:25 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2342F12EB85 for <quic-issues@ietf.org>; Mon, 22 May 2017 12:00:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=VKidbOXFZn+V1bpTGPp/rbiQYpQ=; b=JkjHmxzFfXHGKiN6 /jewJtjpuE/UJfQayGjUFDEaggFgWO7V8XlqIm40CP0LK/U/v3wxdVQ2D2N32xRA 4yWm73pcovxCsVO6EOv65MaYWe0cr6wRtXvXLNEOGkW1VdxKmjWzBVbPvPUcGlen gfRJBz9wnqeuHCoANCwqvqZM8M0=
Received: by filter0634p1mdw1.sendgrid.net with SMTP id filter0634p1mdw1-17238-59233539-3E 2017-05-22 19:00:09.420968904 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id FjC-W8p0SF2DRSY2JFM0IA for <quic-issues@ietf.org>; Mon, 22 May 2017 19:00:09.381 +0000 (UTC)
Date: Mon, 22 May 2017 12:00:09 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc55a95728343a37ac8a22d7a91ded0e92ba6acc392cf00000001153af73992a169ce0d7b2095@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/498/review/39559720@github.com>
In-Reply-To: <quicwg/base-drafts/pull/498@github.com>
References: <quicwg/base-drafts/pull/498@github.com>
Subject: Re: [quicwg/base-drafts] Version validation fields can't move or change (#498)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59233539402f0_1ad93fa337233c2c215ec"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak27//e5v52YuL5qKGeCHuPS/7LCJHpq6mEjbl uMU8vo5FFYB74pNiQ8PLr27k8eG1i3RWDst6tnJmZKfiR9DqHfYo8PmDppQJwQSutgaBH+w82U4Pwo +AOEF3xCxsX3F8XkysAHlOxvDG6JJuUGFusRJ7LFNnH2MCCCCsc53KCwIZliit1tSst7VHPR/1nQDU w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/g1-e0jc6PwThYXDpJEVzgkE6VOc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 May 2017 19:00:26 -0000
ianswett commented on this pull request. > @@ -1131,6 +1131,13 @@ client MUST terminate with a QUIC_VERSION_NEGOTIATION_MISMATCH error code if version negotiation occurred but it would have selected a different version based on the value of the supported_versions list. +The position and size of the version validation fields in the transport +parameters MUST NOT change between different versions of QUIC. If a version of +QUIC needs to define a new format for transport parameters, it MUST define and +use a new TLS extension rather than redefine the layout of the existing I believe I now understand what you're saying. I keep thinking the entire packet is protected, but it's not. The current wording is still a bit confusing to me, I think Victor had some suggestions on how to make it clearer. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/498#discussion_r117821041
- [quicwg/base-drafts] Version validation fields ca… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… MikkelFJ
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… Victor Vasiliev
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… Mike Bishop
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… janaiyengar
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… janaiyengar
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson