IETF Logo Mail Archive

Re: [quicwg/base-drafts] Reorder HTTP frame fields to put Type first (#1351)

Dirkjan Ochtman <notifications@github.com> Fri, 11 May 2018 14:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3643312D0C3 for <quic-issues@ietfa.amsl.com>; Fri, 11 May 2018 07:09:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tEo0IuOmiV1r for <quic-issues@ietfa.amsl.com>; Fri, 11 May 2018 07:09:45 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD7B51200C1 for <quic-issues@ietf.org>; Fri, 11 May 2018 07:09:44 -0700 (PDT)
Date: Fri, 11 May 2018 07:09:44 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1526047784; bh=WoHtOgfM1O8R/K3X0a4Qt2clLMAoWJIsVhYZObjtwAE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dkvkIinf29viIw6iI5U/qMgo0fYiEg8VK0ulXkt+KrSGZKu6a/+a0vB+435H+ucb1 N7HdarAMNfpWOt6R693Y4gAvBna+uMyO4jS8a22M0O2Yk2eJ5gtFJE+bc8dAQAqdya kkzfjy5DqnoUKsUh+lgZLxGBrMPoPVWKORbme2AM=
From: Dirkjan Ochtman <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf9ab0db094bb0dc40747c736f3bb18ddd603838392cf00000001170d662892a169ce1335e6ee@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1351/388374835@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1351@github.com>
References: <quicwg/base-drafts/issues/1351@github.com>
Subject: Re: [quicwg/base-drafts] Reorder HTTP frame fields to put Type first (#1351)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5af5a4283a189_4a693febda190f7c16866c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: djc
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/g9BPqZ1FuFbVIyzeFoLaPc65LsY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2018 14:09:46 -0000

Why is that better? I don't think I necessarily agree. Having to pass the length to the type-specific parser makes the interface different from the one in other places, as explained, and more tightly bound.

Additionally, I prefer having variable-sized fields after types of statically known size.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1351#issuecomment-388374835

v2.31.3 | Report a Bug | By Email | System Status