Date: Wed, 23 Aug 2017 00:20:31 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abde72fc79ee598f4b6fa91464651b27c3eac8407192cf0000000115b48c4f92a169ce0f02be56@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/744/review/57946065@github.com>
In-Reply-To: <quicwg/base-drafts/pull/744@github.com>
References: <quicwg/base-drafts/pull/744@github.com>
Subject: Re: [quicwg/base-drafts] Keep-alive requirements (#744)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_599cca4f45fc1_1fd43f8a50defc3c745c4";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gFWuohqCu0_4ElF1yHmauRSK1hU>

----==_mimepart_599cca4f45fc1_1fd43f8a50defc3c745c4
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson commented on this pull request.



> -packet containing this frame. The PING frame SHOULD be used to keep a connection
-alive when a stream is open. The default is to send a PING frame after 15
-seconds of quiescence. A PING frame has no additional fields.
+packet containing this frame.
+
+A PING frame has no additional fields.
+
+The PING frame can be used to keep a connection alive when an application or
+application protocol wishes to avoid the connection from timing out.  An
+application protocol SHOULD provide guidance about the conditions under which
+generating a PING is recommended.  This guidance SHOULD indicate whether it is
+the client or the server that is expected to send the PING.  Having both
+endpoints send PING frames without coordination can cause excessive number of
+packets and poor performance.
+
+A connection will time out if no packets are for a period longer than the time

Whoops :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/744#discussion_r134632068
----==_mimepart_599cca4f45fc1_1fd43f8a50defc3c745c4
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/744#discussion_r134632068">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; -packet containing this frame. The PING frame SHOULD be used to keep a connection
-alive when a stream is open. The default is to send a PING frame after 15
-seconds of quiescence. A PING frame has no additional fields.
+packet containing this frame.
+
+A PING frame has no additional fields.
+
+The PING frame can be used to keep a connection alive when an application or
+application protocol wishes to avoid the connection from timing out.  An
+application protocol SHOULD provide guidance about the conditions under which
+generating a PING is recommended.  This guidance SHOULD indicate whether it is
+the client or the server that is expected to send the PING.  Having both
+endpoints send PING frames without coordination can cause excessive number of
+packets and poor performance.
+
+A connection will time out if no packets are for a period longer than the time
</pre>
<p>Whoops :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/744#discussion_r134632068">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkqyjm_to6gWYc1W5yGWleF9FuDlAwks5sa3BPgaJpZM4O-HTW">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AWbkqwZ3B0PikeUtvFuOoVkeM_zaN7TVks5sa3BPgaJpZM4O-HTW.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/quicwg/base-drafts/pull/744#discussion_r134632068"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@martinthomson commented on #744"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/744#discussion_r134632068"}}}</script>
----==_mimepart_599cca4f45fc1_1fd43f8a50defc3c745c4--