IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)

mirjak <notifications@github.com> Fri, 21 August 2020 13:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 37D433A0963 for <quic-issues@ietfa.amsl.com>; Fri, 21 Aug 2020 06:05:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QiBfygZIS3GA for <quic-issues@ietfa.amsl.com>; Fri, 21 Aug 2020 06:05:44 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 150F03A0964 for <quic-issues@ietf.org>; Fri, 21 Aug 2020 06:05:44 -0700 (PDT)
Received: from github-lowworker-39b4a70.va3-iad.github.net (github-lowworker-39b4a70.va3-iad.github.net [10.48.16.66]) by smtp.github.com (Postfix) with ESMTP id 2411D56005C for <quic-issues@ietf.org>; Fri, 21 Aug 2020 06:05:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598015143; bh=r3lqWOqtCQ0fNOanVfkkomNktvgV3JUI6y/027lhhWk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hR45CX4aAv79p4vgdCFZK+dAGUnUIezp5fplVvhckt3gyJo74drCtTvEu8LxxSlo1 S1DKw/0UjKiLi0VEnoiThwYy0OAvxniFNZfajM+AvET3uAttcGn2OYCGuwEOCizQSS zxlRr9YkPcD3zgT88kl8BeOO4BQHdv0rbNbJZL7k=
Date: Fri, 21 Aug 2020 06:05:43 -0700
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7BQSWTCAU5HWYVOU55JOT2PEVBNHHCQBGZIM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3978/review/472470226@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3978@github.com>
References: <quicwg/base-drafts/pull/3978@github.com>
Subject: Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3fc6a7149e3_33f819641082f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gKleQ_7Q8f-737dbAUXJIxMYPqQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Aug 2020 13:05:45 -0000

@mirjak commented on this pull request.



>  
 ## Congestion Avoidance
 
-Slow start exits to congestion avoidance.  Congestion avoidance uses an
-Additive Increase Multiplicative Decrease (AIMD) approach that increases
-the congestion window by one maximum packet size per congestion window
-acknowledged.  When a loss or ECN-CE marking is detected, NewReno halves
-the congestion window, sets the slow start threshold to the new
-congestion window, and then enters the recovery period.
+Congestion avoidance uses an Additive Increase Multiplicative Decrease (AIMD)
+approach that typically increases the congestion window by one maximum datagram
+size per congestion window acknowledged, and MUST NOT increase the congestion

Then I don't see why this need to be a normative requirement.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3978#discussion_r474683521

v2.23.0 | Report a Bug | By Email