Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)

[Martin Thomson <[e-mail]>]

martinthomson requested changes on this pull request.



>      // Crypto retransmission timeout.
     RetransmitUnackedCryptoData()
     crypto_count++
+  else if (endpoint is client without 1-RTT keys):
+    if (handshake keys available)

```suggestion
    if (handshake keys available):
```

Unfortunately, this is still incorrect.  As we discussed on https://github.com/quicwg/base-drafts/issues/2519#issuecomment-472671420 there is a requirement to pad any time the client needs to send an Initial packet (it's a little more complicated in practice, but this is what the resolution boils down to). 

>    // Retransmit crypto data if no packets were lost
   // and there are still crypto packets in flight.
-  else if (crypto packets are in flight):
+  if (crypto packets are in flight):
     // Crypto retransmission timeout.
     RetransmitUnackedCryptoData()

I assume that RetransmitUnackedCryptoData() is going to catch any need for padding...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2281#pullrequestreview-220849672