Re: [quicwg/base-drafts] Point out that the payload size could decrease (#3424)

Eric Kinnear <notifications@github.com> Mon, 10 February 2020 07:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0CD00120091 for <quic-issues@ietfa.amsl.com>; Sun, 9 Feb 2020 23:35:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TZdfbbF4-quw for <quic-issues@ietfa.amsl.com>; Sun, 9 Feb 2020 23:35:07 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3E54120077 for <quic-issues@ietf.org>; Sun, 9 Feb 2020 23:35:07 -0800 (PST)
Date: Sun, 09 Feb 2020 23:35:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581320107; bh=F55R1Eiy+/UC3Zs0SEEYc6DNYkmO4bmuooljKY/If2w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HTi9uHML8Yxmn6rxUTSN48l/B9qjEO8EmAVbt7KoVQ2ta7f3NFVPuV8NITvMCJOu0 YANNQx5iafGmD0UcAiEkLtT0TnckqWms85Bbhjcv+iekqNfmHOBhEHTUEytdPaCU7G 2swS9OySn4+IZTONzsyGsXGQFE9aknorsyr4BY+k=
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYW5KSNCPRSJGCWCHV4JY5CVEVBNHHCCZVWTY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3424/review/355731577@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3424@github.com>
References: <quicwg/base-drafts/pull/3424@github.com>
Subject: Re: [quicwg/base-drafts] Point out that the payload size could decrease (#3424)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4107aaeaf49_25583fbf14acd95c304220"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gS3g8ZzttnfmHeyrTDrrGplj5LU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Feb 2020 07:35:09 -0000

erickinnear approved this pull request.

Looking great! One minor wording suggestion.

> @@ -3374,9 +3374,11 @@ priorities specified by the application indicate otherwise (see
 
 Even though a sender is encouraged to assemble frames containing up-to-date
 information every time it sends a packet, it is not forbidden to retransmit
-copies of frames from lost packets.  A receiver MUST accept packets containing
-an outdated frame, such as a MAX_DATA frame carrying a smaller maximum data than
-one found in an older packet.
+copies of frames from lost packets.  A sender which retransmits copies of frames
+must deal with decreases in available payload size due to change in packet

Lowercase `must` makes me read this oddly, how about: 
```suggestion
needs to handle decreases in available payload size due to change in packet
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3424#pullrequestreview-355731577