Re: [quicwg/base-drafts] Fix stale reference and edge case in GOAWAY text (#2634)

Jana Iyengar <notifications@github.com> Fri, 19 April 2019 20:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 25D7C120119 for <quic-issues@ietfa.amsl.com>; Fri, 19 Apr 2019 13:19:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7h28SDFE6uTH for <quic-issues@ietfa.amsl.com>; Fri, 19 Apr 2019 13:19:04 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49F6B12004A for <quic-issues@ietf.org>; Fri, 19 Apr 2019 13:19:04 -0700 (PDT)
Date: Fri, 19 Apr 2019 13:19:03 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555705143; bh=4wDFGMgDoS+UQwpM5GayQSUDK2slj7EF+N1BNRrlcII=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=r90DuvwtJ987fuZ6CTtoeX3dD/304bHoARgg+nbD9i1Gbkoc4Cr59TN90tzKNmD5L aBMyyzYuxtVTNou+2NaZLwxoBRVWNV8Ueyg5w8l7eLbR2QjDT05yW18Pk6+O1NWaZT LS5c2ooOAWDfWrew6OELPdoOvMSjQjY5osmWdiR8=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYKFLPGZC6YYUCEDHV2Y5P3PEVBNHHBT3IA2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2634/review/228814637@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2634@github.com>
References: <quicwg/base-drafts/pull/2634@github.com>
Subject: Re: [quicwg/base-drafts] Fix stale reference and edge case in GOAWAY text (#2634)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cba2d3738a38_20413fdbe48cd96c812ad"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gWXII9CA2iJW9CqkGLt4g0zhAho>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Apr 2019 20:19:06 -0000

janaiyengar commented on this pull request.



> @@ -1318,6 +1318,10 @@ connection to become idle, or MAY initiate an immediate closure of the
 connection.  An endpoint that completes a graceful shutdown SHOULD use the
 HTTP_NO_ERROR code when closing the connection.
 
+If a client has consumed all available bidirectional stream IDs with requests,
+the server need not send a GOAWAY frame; the client is unable to make further

```suggestion
the server need not send a GOAWAY frame, since the client is unable to make further
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2634#pullrequestreview-228814637