IETF Logo Mail Archive

Re: [quicwg/base-drafts] GREASE the flags byte (#311)

Marten Seemann <notifications@github.com> Wed, 15 February 2017 13:34 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 18785129534 for <quic-issues@ietfa.amsl.com>; Wed, 15 Feb 2017 05:34:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.02
X-Spam-Level:
X-Spam-Status: No, score=-2.02 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bmw4SCLng5iw for <quic-issues@ietfa.amsl.com>; Wed, 15 Feb 2017 05:34:50 -0800 (PST)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B6738129508 for <quic-issues@ietf.org>; Wed, 15 Feb 2017 05:34:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=dACOeAVL1dgL8DWeaaor8KHfCyg=; b=e0i1ep3/17LTfAJk vyp3OBSuiwkKxjszxmX4UfeMcR1vlFanNK9mJJJ/nTQ6+b4SG3MWi7+7pRpdIjXc kS2yjygdg5Bc4gadF99ILiIZLzxQnVIJbnK/zapWTADNjqp6UOCJOwXxXD/ajEWK Z2WaYLQ7xxzmicuM+sRT2kj7mmU=
Received: by filter0621p1mdw1.sendgrid.net with SMTP id filter0621p1mdw1-11587-58A458D4-31 2017-02-15 13:34:12.424181632 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id hdXlF12bSteMmeislU4cCA for <quic-issues@ietf.org>; Wed, 15 Feb 2017 13:34:12.418 +0000 (UTC)
Date: Wed, 15 Feb 2017 05:34:12 -0800
From: Marten Seemann <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/311/280011603@github.com>
In-Reply-To: <quicwg/base-drafts/issues/311@github.com>
References: <quicwg/base-drafts/issues/311@github.com>
Subject: Re: [quicwg/base-drafts] GREASE the flags byte (#311)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_58a458d44b86a_25653fbd0eea5140329511"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3QwI5PiEbpqlHr815qXPXqZehM0H5aop7UrZ JJJQxit+1PvYxyAH0BuxiYBA0+OtndvWcO5cBMUSKzSNjpKxtdXil55p/VWJs8nPOsuCqSR9DXVj6o Mr6nhck9j3MB2sgPqItN5mZ0yjWggXoy3hMmuQ2e06gtEAlWq0YANBaQi9Isf+CEMUJ3NyqEQF9k+A A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gd1whA1lBGeZtTkSKduKQPKJQME>
Cc: Subscribed <subscribed@noreply.github.com>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quic@ietf.org
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Feb 2017 13:34:53 -0000

I like this idea very much. 

I thinkwe have to be a bit more careful when it comes to the long packets. Different QUIC versions might define a different number of packet types, so we can't grease before version negotiation is finished. If I understand that correctly, excluding the long packets from treason would solve that problem (we do slightly modified greasing here if we define a fixed modulo value that is guaranteed to stay constant between all QUIC versions). 

Furthermore, in order to simplify the mapping, if we define an ordering of the frame types anyway, wouldn't it be easier to get rid of the explicit values defined in Jana's proposal? I.e. the packet type would just be numbered 1 to n. 

Then the rule for the sender is easy: Just add *random number* x *number of frame types* to the type number (mod 256).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/311#issuecomment-280011603

v2.46.0 | Report a Bug | By Email | System Status