Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)

Martin Thomson <notifications@github.com> Sun, 16 February 2020 23:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0C3FC120024 for <quic-issues@ietfa.amsl.com>; Sun, 16 Feb 2020 15:44:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pPQTOE3WTsHX for <quic-issues@ietfa.amsl.com>; Sun, 16 Feb 2020 15:44:16 -0800 (PST)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 52E1112001B for <quic-issues@ietf.org>; Sun, 16 Feb 2020 15:44:16 -0800 (PST)
Date: Sun, 16 Feb 2020 15:44:15 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581896655; bh=nZHm6pfEhlbmgg4+7RTpyTySuEnDx5iw+uIdYAvC0VU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QfWpyGwjE7UVsaDil982rX5hlMPUihpq/d4jRMMfEijt6pjGtnH1BFWsDUKQwxvCo SMXG1UU6lUuyZch6k18fKiiq8p2VFmzxxtZrQcu8zMKK6R/VEb0EO9LoYZ9BRYRC3J oXfffkrJ/F8Ja1H9saUP8ovsDDwbaEMZnqVYQ5Yk=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5BYZXO467NOL2SPXV4K4DE7EVBNHHCDOLCFM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3461/review/359439734@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3461@github.com>
References: <quicwg/base-drafts/pull/3461@github.com>
Subject: Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e49d3cf3dd8c_217b3f9cb50cd9606808c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/geWBNZnjoHKcpr1L3yD9dtgZhc8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Feb 2020 23:44:18 -0000

martinthomson commented on this pull request.



> @@ -1179,20 +1179,20 @@ OnLossDetectionTimeout():
     SetLossDetectionTimer()
     return
 
-  if (endpoint is client without 1-RTT keys):
+  if (bytes_in_flight > 0):
+    // PTO. Send new data if available, else retransmit old data.
+    // If neither is available, send a single PING frame.
+    _, pn_space = GetEarliestTimeAndSpace(
+      time_of_last_sent_ack_eliciting_packet)
+    SendOneOrTwoAckElicitingPackets(pn_space)
+  else:

```suggestion
  else if client:
```

Otherwise, the server might hit this path if it has sent HelloRetryRequest and had it acknowledged.  In that case, the server has to sit tight.  It's a perverse scenario, but PQ is coming...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3461#pullrequestreview-359439734