IETF Logo Mail Archive

Re: [quicwg/base-drafts] Incorporate F-RTO (#409)

ianswett <notifications@github.com> Tue, 21 March 2017 20:44 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 389AF128B88 for <quic-issues@ietfa.amsl.com>; Tue, 21 Mar 2017 13:44:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.402
X-Spam-Level:
X-Spam-Status: No, score=-0.402 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XAwkDJ8g_fth for <quic-issues@ietfa.amsl.com>; Tue, 21 Mar 2017 13:44:29 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A4E312EA6A for <quic-issues@ietf.org>; Tue, 21 Mar 2017 13:44:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=EhBS2iMuXrD8SY+U2c5qCrw//Kk=; b=KWlKzRVbnxR1o0JD 40N0hyLuhBAnWEVPd5mOrm1nveYj0fk83XcrmuzlbF+v4CdN51vr3qeaIzmyyBMf SnY2OSaNRddCcbqB397e19BYbySLKMMKvuWmmEXoMykbJQcBcgnM0vwtUKjB5swk TXCwG64jzD1po4ssXnKJSPyWGXw=
Received: by filter0550p1mdw1.sendgrid.net with SMTP id filter0550p1mdw1-31295-58D190AB-2B 2017-03-21 20:44:27.626741783 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id PvalqQaST1Cd6SKg24fzzg for <quic-issues@ietf.org>; Tue, 21 Mar 2017 20:44:27.665 +0000 (UTC)
Date: Tue, 21 Mar 2017 13:44:27 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8574958b1b7bbfc4595d48d06c0a086daa82431192cf0000000114e952ab92a169ce0cd39eb5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/409/review/28232320@github.com>
In-Reply-To: <quicwg/base-drafts/pull/409@github.com>
References: <quicwg/base-drafts/pull/409@github.com>
Subject: Re: [quicwg/base-drafts] Incorporate F-RTO (#409)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_58d190ab8ff5e_53a73fc303737c3c6744f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0kBQ7PLjUx8AkSdT7bSGaa/1DkHUPcH9p+Aq G5Og1OThumFZqdYYiWoN9ofClssxRgSmAOtIOfCdPt9LDfMYZ960lWM1ojY/2cssunJn74hcL222OY fDbAJmT7Pm7OPRvBkKZoJssnOyc+kAN9HlZJAFD3++oxC9GtgIfenKc6Eh0eHlax6/WPu4J02CS4TX w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gjZw2RWxnjc82VgZFM3muqscFe0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Mar 2017 20:44:31 -0000

ianswett commented on this pull request.



>       if (end_of_recovery < largest_lost_packet.packet_number):
        end_of_recovery = largest_sent_packet
        congestion_window *= kLossReductionFactor
+       congestion_window = max(congestion_window, kMinimumWindow)

I tried, but it ends up taking up 3 lines, so I just kept it as is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/409#discussion_r107270104

v2.46.0 | Report a Bug | By Email | System Status