Re: [quicwg/base-drafts] Change on idle behaviour (#2553)

ianswett <notifications@github.com> Tue, 26 March 2019 11:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E61621202BD for <quic-issues@ietfa.amsl.com>; Tue, 26 Mar 2019 04:23:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7mGSDSY7Y8oT for <quic-issues@ietfa.amsl.com>; Tue, 26 Mar 2019 04:23:43 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A12EC120160 for <quic-issues@ietf.org>; Tue, 26 Mar 2019 04:23:43 -0700 (PDT)
Date: Tue, 26 Mar 2019 04:23:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1553599422; bh=V0/GFs3et6M+HGVGh+qsyavymXVrgN6ZAkn42NoCats=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qprUnP0W7wR61NKlAmHze09yLM/LznylONdEuGpmKqf8fy74ch8hb0EUnJVHZewSd RAyFgnHP04XzFrWT2szFBqd3j7ep6dJ0TkKqrpRqIz+TafvUa9iHFpfukkZuioBB0l dfx2MHTjc97dX47RsdUE/h5Dy2hLblckS65GMWoo=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab46e91fc0714f7147272ac2595fb07d90ce9172ac92cf0000000118b1cdbe92a169ce1959e0d1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2553/review/218826720@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2553@github.com>
References: <quicwg/base-drafts/pull/2553@github.com>
Subject: Re: [quicwg/base-drafts] Change on idle behaviour (#2553)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c9a0bbe16398_26273fc7524d45b41796e5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/guYKBzuItcmYpG4DWeCZYEokudQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Mar 2019 11:23:46 -0000

ianswett commented on this pull request.

I think this looks good, some small suggestions. 

> @@ -724,13 +724,11 @@ in Linux (3.11 onwards).
 A sender becomes idle if it ceases to send data and has no bytes in flight.  A
 sender's congestion window MUST NOT increase while it is idle.
 
-When sending data after becoming idle, a sender MUST reset its congestion window
-to the initial congestion window (see Section 4.1 of {{?RFC5681}}), unless it
-paces the sending of packets. A sender MAY retain its congestion window if it
-paces the sending of any packets in excess of the initial congestion window.
-
-A sender MAY implement alternate mechanisms to update its congestion window
-after idle periods, such as those proposed for TCP in {{?RFC7661}}.
+When sending data after becoming idle and a sender does not pace the sending
+of pacjets, it MUST reset its congestion window to the initial congestion

```suggestion
of packets, it MUST reset its congestion window to the initial congestion
```

> @@ -724,13 +724,11 @@ in Linux (3.11 onwards).
 A sender becomes idle if it ceases to send data and has no bytes in flight.  A
 sender's congestion window MUST NOT increase while it is idle.
 
-When sending data after becoming idle, a sender MUST reset its congestion window
-to the initial congestion window (see Section 4.1 of {{?RFC5681}}), unless it
-paces the sending of packets. A sender MAY retain its congestion window if it
-paces the sending of any packets in excess of the initial congestion window.
-
-A sender MAY implement alternate mechanisms to update its congestion window
-after idle periods, such as those proposed for TCP in {{?RFC7661}}.
+When sending data after becoming idle and a sender does not pace the sending
+of pacjets, it MUST reset its congestion window to the initial congestion
+window (see Section 4.1 of {{?RFC5681}}). A sender MAY implement alternate

Suggestion: "If packet sending is paced, a sender MAY implement alternate mechanisms to update its congestion window after idle periods, such as those proposed for TCP in {{?RFC7661}}.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2553#pullrequestreview-218826720