Re: [quicwg/base-drafts] Split error code space (#722)
Martin Thomson <notifications@github.com> Wed, 06 September 2017 01:20 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A31E132D8E for <quic-issues@ietfa.amsl.com>; Tue, 5 Sep 2017 18:20:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.596
X-Spam-Level:
X-Spam-Status: No, score=-5.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5LRrcVEbkMTR for <quic-issues@ietfa.amsl.com>; Tue, 5 Sep 2017 18:20:27 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext1.iad.github.net [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49DC51252BA for <quic-issues@ietf.org>; Tue, 5 Sep 2017 18:20:26 -0700 (PDT)
Date: Tue, 05 Sep 2017 18:20:25 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1504660825; bh=waq+1VOkNa4TsPBr5YUrLtHCllyfJ+f8tg+Keh/pn5s=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=m2Tlmo4uDbeL/suhqEU+q56UdaF0+E9TS0tIuyOwuP4NPtdelLXBsLdwqOc8xV0Ua 99whYR9DnF8tL7GjOpjBtJjZ6XLQtlRLRqxGCK3JHKNLPq5mYTZUC+LmF6HjZuub1Y 5lYBZM/QAjyHpb62VK/C9XBSZq8MRy6a5xN8oPsw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcdfbab1c30b2580a423215324f9d90d7dcafe2ea92cf0000000115c70f5992a169ce0edfabce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/722/review/60782546@github.com>
In-Reply-To: <quicwg/base-drafts/pull/722@github.com>
References: <quicwg/base-drafts/pull/722@github.com>
Subject: Re: [quicwg/base-drafts] Split error code space (#722)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59af4d596e7f2_43ea3fa75ac13c3412768f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gwO21HQrt0OGXaZLFk6sEu2CB2c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Sep 2017 01:20:30 -0000
martinthomson commented on this pull request. > @@ -2608,11 +2654,10 @@ discarded upon receipt. This avoids potential ambiguity about which STREAM frames count toward flow control. Upon receipt of a STOP_SENDING frame on a stream in the "open" or "half-closed -(remote)" states, an endpoint MUST send a RST_STREAM with an error code of -QUIC_RECEIVED_RST. If the STOP_SENDING frame is received on a stream that is -already in the "half-closed (local)" or "closed" states, a RST_STREAM frame MAY -still be sent in order to cancel retransmission of previously-sent STREAM -frames. +(remote)" states, an endpoint MUST send a RST_STREAM frame. If the STOP_SENDING I agree. I think that I'd rather do the move of STOP_SENDING, but I'll tweak the text here in case someone objects to the other PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/722#discussion_r137152479
- [quicwg/base-drafts] Split error code space (#722) Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… janaiyengar
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Mark Nottingham
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… janaiyengar
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Mike Bishop
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… janaiyengar
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… janaiyengar
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… janaiyengar
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… Martin Thomson
- Re: [quicwg/base-drafts] Split error code space (… janaiyengar
- Re: [quicwg/base-drafts] Split error code space (… janaiyengar