Re: [quicwg/base-drafts] Clarify ICMP PTB message validation (#2109)
Martin Thomson <notifications@github.com> Thu, 13 December 2018 23:39 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61482130EBA for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 15:39:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QxuWRuhFgnKa for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 15:39:52 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 75BA8130E26 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 15:39:52 -0800 (PST)
Date: Thu, 13 Dec 2018 15:39:51 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544744391; bh=9panOMqZc3RC8fZYHwLca0hlDmibNXb22ZYAHkAyUec=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=y6zvmdWed4q5xQ1oVCrx8zVty1RJ12w6fz1ga7+W39yZCkAAbfdiaPK+iZKKPoz+v hk6XgvF8QNbyDJTyQXQpRlEKwwVy623fiWKk101eaYS/VDrWQzvVMfj6q4Ppm6fJ8y UMP57hpcx88rA//7RWG3L6B08rEx5j+i9CF//Mng=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba201dd718072677caa45eccf5c91f3ca0284e13a92cf00000001182aafc792a169ce1731b88c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2109/review/184918199@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2109@github.com>
References: <quicwg/base-drafts/pull/2109@github.com>
Subject: Re: [quicwg/base-drafts] Clarify ICMP PTB message validation (#2109)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c12edc77b24b_15243f80b68d45c01130c7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gwzPvCtDqhz5VwNuO1vJntRz4ww>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 23:39:54 -0000
martinthomson approved this pull request. I'm OK with this (it deletes text, how can I resist). But I want to understand @gorryfair's concerns better. > -As a part of ICMP validation, QUIC endpoints SHOULD validate that connection ID -information corresponds to an active session. +ICMP message validation SHOULD include matching IP addresses and UDP ports ```suggestion ICMP message validation MUST include matching IP addresses and UDP ports ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2109#pullrequestreview-184918199
- [quicwg/base-drafts] Endpoints MAY (not SHOULD) i… Igor Lubashev
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Martin Thomson
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Igor Lubashev
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Martin Thomson
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Igor Lubashev
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Martin Thomson
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Gorry Fairhurst
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Igor Lubashev
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Martin Thomson
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Igor Lubashev
- Re: [quicwg/base-drafts] Endpoints MAY (not SHOUL… Gorry Fairhurst
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… Igor Lubashev
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… Martin Thomson
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… Gorry Fairhurst
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… Igor Lubashev
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… Igor Lubashev
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… ianswett
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… Martin Thomson
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… janaiyengar
- Re: [quicwg/base-drafts] Clarify ICMP PTB message… Martin Thomson