Re: [quicwg/base-drafts] Clarify ICMP PTB message validation (#2109)

Martin Thomson <> Thu, 13 December 2018 23:39 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 61482130EBA for <>; Thu, 13 Dec 2018 15:39:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id QxuWRuhFgnKa for <>; Thu, 13 Dec 2018 15:39:52 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 75BA8130E26 for <>; Thu, 13 Dec 2018 15:39:52 -0800 (PST)
Date: Thu, 13 Dec 2018 15:39:51 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1544744391; bh=9panOMqZc3RC8fZYHwLca0hlDmibNXb22ZYAHkAyUec=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=y6zvmdWed4q5xQ1oVCrx8zVty1RJ12w6fz1ga7+W39yZCkAAbfdiaPK+iZKKPoz+v hk6XgvF8QNbyDJTyQXQpRlEKwwVy623fiWKk101eaYS/VDrWQzvVMfj6q4Ppm6fJ8y UMP57hpcx88rA//7RWG3L6B08rEx5j+i9CF//Mng=
From: Martin Thomson <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2109/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Clarify ICMP PTB message validation (#2109)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c12edc77b24b_15243f80b68d45c01130c7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Thu, 13 Dec 2018 23:39:54 -0000

martinthomson approved this pull request.

I'm OK with this (it deletes text, how can I resist).  But I want to understand @gorryfair's concerns better.

-As a part of ICMP validation, QUIC endpoints SHOULD validate that connection ID
-information corresponds to an active session.
+ICMP message validation SHOULD include matching IP addresses and UDP ports

ICMP message validation MUST include matching IP addresses and UDP ports

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: