Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 88F4512F1A6
 for <quic-issues@ietfa.amsl.com>; Wed,  1 Aug 2018 21:21:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level: 
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 6y7jX2WvFp0N for <quic-issues@ietfa.amsl.com>;
 Wed,  1 Aug 2018 21:21:54 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id CEBD6130DC3
 for <quic-issues@ietf.org>; Wed,  1 Aug 2018 21:21:53 -0700 (PDT)
Date: Wed, 01 Aug 2018 21:21:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1533183712;
 bh=9RoR5ptgiPKXMU2RyD79KPngYZnmjCPGMYGotyV/9kk=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=MVViHPx6LbFxDWN8UQw6QOPGv+7sUn+98sB0ZPf9cUcTZe4EZtbx/gcHOgjgi9Zx8
 0ntYZxys9ZqNKFo8FgTjOzjaA9PSpJuPJkWBQR0GM9d1RGCw7LZYDjh4MxebwqpWxo
 Gtq0+U6prYVdBcsEzsz1wk4s9cY2iR1hn29fHKbQ=
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abe83bfdd0e7b8efb104f69ae4d57da7652b6d129492cf00000001177a48e092a169ce14a0100a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1614/review/142639404@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1614@github.com>
References: <quicwg/base-drafts/pull/1614@github.com>
Subject: Re: [quicwg/base-drafts] Define idle timeout more precisely (#1614)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b6286e08be25_47303feb8fcd45b41571d5";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/gzjMGrcmHk6DRTMsENA0APMH8Bg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 04:21:57 -0000


----==_mimepart_5b6286e08be25_47303feb8fcd45b41571d5
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

siyengar approved this pull request.

Otherwise this looks great. Thanks for putting up the pr to clarify thing=
s.

>  {{transport-parameter-definitions}}) is closed.  A connection enters t=
he
 draining state when the idle timeout expires.
 =

-The time at which an idle timeout takes effect won't be perfectly synchr=
onized
-on both endpoints.  An endpoint that sends packets near the end of an id=
le
-period could have those packets discarded if its peer enters the drainin=
g state
-before the packet is received.
+Endpoints use the value they advertise when determining an idle timeout.=
  The

You talk about the asymmetric nature of idle timeout later, but maybe use=
ful to say this before.

=E2=80=9CEach endpoint advertises their own idle timeout to the peer=E2=80=
=9D.

>  {{transport-parameter-definitions}}) is closed.  A connection enters t=
he
 draining state when the idle timeout expires.
 =

-The time at which an idle timeout takes effect won't be perfectly synchr=
onized
-on both endpoints.  An endpoint that sends packets near the end of an id=
le
-period could have those packets discarded if its peer enters the drainin=
g state
-before the packet is received.
+Endpoints use the value they advertise when determining an idle timeout.=
  The
+idle timeout starts from the last packet received, or the first packet s=
ent
+after sending that packet.  The latter condition ensures that initiating=
 new
+activity postpones a timeout.
+
+The value for an idle timeout can be asymmetric.  The value advertised b=
y a peer
+is only used to determine whether the connection is live at a peer.  An =
endpoint

Maybe less confusing to say a value =E2=80=9Cadvertised by an endpoint ..=
. is live at an endpoint=E2=80=9D

-- =

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1614#pullrequestreview-1426394=
04=

----==_mimepart_5b6286e08be25_47303feb8fcd45b41571d5
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@siyengar</b> approved this pull request.</p>

<p>Otherwise this looks great. Thanks for putting up the pr to clarify th=
ings.</p><hr>

<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/1614#discussi=
on_r207097300">draft-ietf-quic-transport.md</a>:</p>
<pre style=3D'color:#555'>&gt;  {{transport-parameter-definitions}}) is c=
losed.  A connection enters the
 draining state when the idle timeout expires.
 =

-The time at which an idle timeout takes effect won&#39;t be perfectly sy=
nchronized
-on both endpoints.  An endpoint that sends packets near the end of an id=
le
-period could have those packets discarded if its peer enters the drainin=
g state
-before the packet is received.
+Endpoints use the value they advertise when determining an idle timeout.=
  The
</pre>
<p>You talk about the asymmetric nature of idle timeout later, but maybe =
useful to say this before.</p>
<p>=E2=80=9CEach endpoint advertises their own idle timeout to the peer=E2=
=80=9D.</p>

<hr>

<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/1614#discussi=
on_r207097873">draft-ietf-quic-transport.md</a>:</p>
<pre style=3D'color:#555'>&gt;  {{transport-parameter-definitions}}) is c=
losed.  A connection enters the
 draining state when the idle timeout expires.
 =

-The time at which an idle timeout takes effect won&#39;t be perfectly sy=
nchronized
-on both endpoints.  An endpoint that sends packets near the end of an id=
le
-period could have those packets discarded if its peer enters the drainin=
g state
-before the packet is received.
+Endpoints use the value they advertise when determining an idle timeout.=
  The
+idle timeout starts from the last packet received, or the first packet s=
ent
+after sending that packet.  The latter condition ensures that initiating=
 new
+activity postpones a timeout.
+
+The value for an idle timeout can be asymmetric.  The value advertised b=
y a peer
+is only used to determine whether the connection is live at a peer.  An =
endpoint
</pre>
<p>Maybe less confusing to say a value =E2=80=9Cadvertised by an endpoint=
 ... is live at an endpoint=E2=80=9D</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/1614#pullrequestreview-142639404">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq=
3fdmjewdr9Z3YmuVA6bKkkd2IvFks5uMn5ggaJpZM4VnmA4">mute the thread</a>.<img=
 src=3D"https://github.com/notifications/beacon/AWbkq4o0Pj6Wmskc1MIeSzHhJ=
2OEiqs0ks5uMn5ggaJpZM4VnmA4.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=

<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@siye=
ngar approved #1614"}],"action":{"name":"View Pull Request","url":"https:=
//github.com/quicwg/base-drafts/pull/1614#pullrequestreview-142639404"}}}=
</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1614#pullrequestrev=
iew-142639404",
"url": "https://github.com/quicwg/base-drafts/pull/1614#pullrequestreview=
-142639404",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@siyengar approved 1614",
"sections": [
{
"text": "Otherwise this looks great. Thanks for putting up the pr to clar=
ify things.",
"activityTitle": "**Subodh Iyengar**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@siyengar",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1614#pullrequestreview=
-142639404"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 3627008=
56\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5b6286e08be25_47303feb8fcd45b41571d5--

