Re: [quicwg/base-drafts] Transport editorial suggestions (#2731)

Martin Thomson <notifications@github.com> Wed, 22 May 2019 13:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C3C8120046 for <quic-issues@ietfa.amsl.com>; Wed, 22 May 2019 06:02:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.606
X-Spam-Level:
X-Spam-Status: No, score=-1.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A19QTARRXaNh for <quic-issues@ietfa.amsl.com>; Wed, 22 May 2019 06:02:54 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50AD7120074 for <quic-issues@ietf.org>; Wed, 22 May 2019 06:02:54 -0700 (PDT)
Date: Wed, 22 May 2019 06:02:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1558530173; bh=29jeBs589k11zb+YANWAtvQttBXZJGA8DtOwFEu0OvM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dvQRQ5j81KJOn2saiG1uBBylDpDNyoygBhHMpcBbxceJJ8zAYabjSjfJHVS377tQj pYs4FtuWCI3wFQPGVj6vhD+OtGxeXbp2GR5lMeyAIu2CcPzyiIV7U2KYKGFKeGY4bZ 4V0+ervn9zvNsY5E20+wRKBEh1Mhd2Ah5+VVykTw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZNUHY24PO37KOTL4N26J5PZEVBNHHBVGVFRE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2731/review/240614043@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2731@github.com>
References: <quicwg/base-drafts/pull/2731@github.com>
Subject: Re: [quicwg/base-drafts] Transport editorial suggestions (#2731)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ce5487ce7f2e_7deb3ff3a10cd9681501bc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/h-FoCG1k1Bdnq-_1VxXReN-9r1s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 May 2019 13:02:57 -0000

martinthomson requested changes on this pull request.

One error here.

> @@ -1336,11 +1335,7 @@ and sets the SCIL field to indicate the length.
 The first flight of 0-RTT packets use the same Destination and Source Connection
 ID values as the client's first Initial.
 
-The Destination Connection ID field in the server's Initial packet contains a
-connection ID that is chosen by the recipient of the packet (i.e., the client);
-the Source Connection ID includes the connection ID that the sender of the
-packet wishes to use (see {{connection-id}}). The server MUST use consistent
-Source Connection IDs during the handshake.
+The server MUST use consistent Source Connection IDs during the handshake.

This implies that the server cannot change its Source Connection ID between sending a Retry and sending an Initial.  I hope that we agree that this is an implausible requirement.  The consistency applies only after sending an Initial.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2731#pullrequestreview-240614043