[quicwg/base-drafts] Sending probe packet has duplicated text (#3468)

mirjak <notifications@github.com> Mon, 17 February 2020 17:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C875B1200C3 for <quic-issues@ietfa.amsl.com>; Mon, 17 Feb 2020 09:48:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NP2TRqXcPxoz for <quic-issues@ietfa.amsl.com>; Mon, 17 Feb 2020 09:48:12 -0800 (PST)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 04D60120089 for <quic-issues@ietf.org>; Mon, 17 Feb 2020 09:48:11 -0800 (PST)
Date: Mon, 17 Feb 2020 09:48:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581961690; bh=QabO63V8J7p5HwIQmwq0n5RKWerdMGYBuMn6b5+sfsI=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=mcmOKcLxUaJx3R8UxmhavnleelaIF5YhqZeGTY2o5mY/282OyNMC1AIi4aOQPpshZ 9ufmzCywxniGA0gUpdshHfH8gr9Sj0EfnUdEpdGhpkz7ymd35aQBAupvbu22Jzjf2O 8YrhFX5OPK3V/I+0qRCnZRuNcaQbYwBhO9zXKupw=
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ7Z54DZHWR3C4J6SF4LACFVEVBNHHCDQ2AF4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3468@github.com>
Subject: [quicwg/base-drafts] Sending probe packet has duplicated text (#3468)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4ad1da3cf41_24ec3fb3632cd96c1685f3"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/h-qPZT6aiq_jx_C_9hjxqSfon0s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Feb 2020 17:48:15 -0000

I removed this text because it was duplicated with text further below in the same section (but different normative requirements). I assume this was an oversight and the text further down is the more current one (at least it makes for sense to me). 

However, I&#39;m not sure if this sentence is still needed, and if so why:
&quot;In addition to sending data in the packet number space for which the timer
expired, the sender SHOULD send ack-eliciting packets from other packet
number spaces with in-flight data, coalescing packets if possible.&quot;
????
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3468

-- Commit Summary --

  * Sending probe packet has duplicated text

-- File Changes --

    M draft-ietf-quic-recovery.md (18)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/3468.patch
https://github.com/quicwg/base-drafts/pull/3468.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3468